Repository navigation
avoid NPE - #4
Merged
Merged
Conversation
gaudenz
requested changes
Oct 27, 2026
gaudenz
left a comment
gaudenz
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix. The code looks good, but it would be nice to copy the explanation in the PR description into the git commit so it's preserved in the git history. Please also rebase onto the current main branch, this will make the workflows pass.
When a server fails to provision, the server object will be empty.
Therefore, the call to server.Name will throw a nil pointer panic:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x977036]
goroutine 42235 [running]:
github.com/cloudscale-ch/fleeting-plugin-cloudscale.(*InstanceGroup).Increase.func1.1({0xc000038990?, 0x0?})
.../provider.go:335 +0x156
created by github.com/cloudscale-ch/fleeting-plugin-cloudscale.(*InstanceGroup).Increase.func1 in goroutine 42233
.../provider.go:323 +0x78
By using the uuid, which will not be nil, we can avoid this issue.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
done. LLM was used for the branch rename and fork rebase. |
gaudenz
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a server fails to provision, the server object will be empty. therefore, the call to
server.Namewill throw a null nil pointerby using the
uuidwhich will not be nil we can avoid this issue.