Skip to content

[multiplex] merge flush and use sharded hashmap #321 - #322

Open
miamia0 wants to merge 1 commit into
cloudwego:mainfrom
miamia0:merge_flush
Open

[multiplex] merge flush and use sharded hashmap #321#322
miamia0 wants to merge 1 commit into
cloudwego:mainfrom
miamia0:merge_flush

Conversation

@miamia0

@miamia0 miamia0 commented Jan 8, 2024

Copy link
Copy Markdown

Motivation

optimize the multiplex transport

  1. use shared hashmap instead of Mutex to reduce race
  2. merge the flush in the write loop

Solution

@miamia0
miamia0 requested review from a team January 8, 2024 06:47
@CLAassistant

CLAassistant commented Jan 8, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@miamia0 miamia0 changed the title [multiplex] merge flush and use shared hashmap #321 [WIP][multiplex] merge flush and use shared hashmap #321 Jan 8, 2024
@choleraehyq

Copy link
Copy Markdown

shared -> sharded?

@miamia0
miamia0 force-pushed the merge_flush branch 3 times, most recently from 8819746 to 98b1479 Compare January 9, 2024 15:34
@miamia0 miamia0 changed the title [WIP][multiplex] merge flush and use shared hashmap #321 [multiplex] merge flush and use shared hashmap #321 Jan 9, 2024
@miamia0 miamia0 changed the title [multiplex] merge flush and use shared hashmap #321 [multiplex] merge flush and use sharded hashmap #321 Jan 10, 2024
@miamia0

miamia0 commented Jan 10, 2024

Copy link
Copy Markdown
Author

@PureWhiteWu PTAL

@@ -1,5 +1,4 @@
pub(crate) mod incoming;
#[cfg(feature = "multiplex")]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为什么删了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants