feat(volo-http client): add redirect-following support - #653
Open
junliurs wants to merge 1 commit into
Open
Conversation
junliurs
force-pushed
the
feat/client-follow-redirects
branch
2 times, most recently
from
July 15, 2026 04:11
016da43 to
a49fc6a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
+ Coverage 46.20% 47.82% +1.62%
==========================================
Files 163 164 +1
Lines 20307 20791 +484
==========================================
+ Hits 9382 9943 +561
+ Misses 10925 10848 -77 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Joshuahoky
reviewed
Jul 15, 2026
| type Error = ClientError; | ||
|
|
||
| async fn call(&self, cx: &mut ClientContext, req: Request<B>) -> Result<Self::Response> { | ||
| if !self |
Contributor
There was a problem hiding this comment.
Missing check if self.max_redirects == 0. if max_redirects is 0, it should return the redirect response as is.
junliurs
force-pushed
the
feat/client-follow-redirects
branch
from
July 20, 2026 03:39
a49fc6a to
792d550
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solution