Repository navigation
Update build environment from PHP 8.1 to PHP 8.5 - #161
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The narrow configuration changes consistently target PHP 8.5, preserve locked dependencies, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
Updates the website’s Docker-based build environment to PHP 8.5, matching the hosting runtime and following the Sculpin dependency upgrade.
Changes:
- Switches the Docker PHP base image and minimum PHP requirement to 8.5.
- Removes the Composer PHP 8.1.8 platform override without changing locked package versions.
- Updates the documented PHP requirement.
| File | Description |
|---|---|
| README.md | Documents PHP 8.5+ as the requirement. |
| Dockerfile | Uses PHP 8.5 for build and runtime stages. |
| composer.lock | Updates platform metadata and removes the override. |
| composer.json | Requires PHP 8.5+ and removes the platform pin. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the build environment from PHP 8.1 to PHP 8.5, which is also what our web hosting already runs. With Sculpin, Twig and Symfony updated in #160, the build now runs on PHP 8.5 without any deprecation notices.
It also removes the Composer
platformsetting that pinned our dependencies to PHP 8.1.8, a leftover from building the website on the web hosting itself before #127. The lock file keeps its current packages for now, so a future update may move a few Symfony components to 7.4.Nothing should change on the website. The generated pages are identical before and after this change, and the integration and Playwright tests pass as before.
Builds on top of #160, #158 and #123
Refs #127