Repository navigation
Improve PHP 8.6+ support by avoiding spl_object_hash() in tests - #313
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only change preserves the identity assertion without introducing newer PHP APIs or affecting production behavior.
No open issues 🎉
What changed in this PR
Updates the container identity test to avoid deprecated spl_object_hash() calls on PHP 8.6+ while retaining PHP 7.1 compatibility.
Changes:
- Compares the injected container directly with the original instance using strict identity.
- Updates the expected JSON response to reflect the boolean result without changing production code.
| File | Description |
|---|---|
| tests/ContainerTest.php | Replaces object-hash comparisons with a direct container identity check. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves PHP 8.6+ support by avoiding the deprecated
spl_object_hash()function in tests. The suggestedspl_object_id()requires PHP 7.2+, so the test now compares the container instance directly to keep supporting PHP 7.1. With these changes applied, tests against the current PHP 8.6 RC pass without errors.Builds on top of #290, #282, #297 and others
Refs https://wiki.php.net/rfc/deprecations_php_8_6#deprecate_spl_object_hash and php/php-src#23074