Repository navigation
Update Docker build to install PHP extensions via PIE instead of PECL - #316
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the PIE migration in the deployment guidance and integration Dockerfile.
No open issues 🎉
What changed in this PR
Migrates the recommended Docker build and deployment guidance from PECL to PIE, preparing for PHP 8.6 images that no longer include PECL.
Changes:
- Adds PIE to the shared build stage and uses it to install
ext-ev, preserving parallel extension build stages. - Updates event-loop extension recommendations to link to Packagist packages.
- Keeps the integration Dockerfile aligned with the documented example.
| File | Description |
|---|---|
| tests/integration/Dockerfile-production | Installs PIE and replaces the PECL command for ext-ev. |
| docs/best-practices/deployment.md | Updates the Docker example and extension installation guidance to PIE. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates our recommended
Dockerfileto install PHP extensions via PIE instead of PECL. PIE is the official successor to the now deprecated PECL (https://wiki.php.net/rfc/adopt_pie_deprecate_pecl), and the upcoming PHP 8.6 images no longer ship thepeclcommand at all (docker-library/php#1654), so this prepares for updating to PHP 8.6 once it is released.PIE installs the same
evextension, now v1.2.4 from Packagist instead of v1.2.3 from PECL, and writes the samedocker-php-ext-ev.inifile as before. Builds keep compiling in parallel stages as per #315 and take about a second longer, the resulting image is otherwise unchanged. Likewise, the documentation for higher file descriptor limits now recommends installingext-ev,ext-eventorext-uvusing PIE.Builds on top of #315, #136, #273, #149 and https://github.com/clue-engineering/icalforcalendly/pull/238 (private)
Refs docker-library/php#1654