fix: distinguish enum from spatial column - #396
Merged
Conversation
BuonOmo
force-pushed
the
fix/enum-name-conflict
branch
2 times, most recently
from
January 20, 2026 09:55
a157e21 to
1784230
Compare
BuonOmo
marked this pull request as ready for review
January 20, 2026 10:27
If an enum name contained a spatial type name (e.g. "point"). It would be matched by a regex as a sql type. This commit is handling that by checking type metadata. See rgeo/activerecord-postgis-adapter#432
rafiss
force-pushed
the
fix/enum-name-conflict
branch
from
January 20, 2026 17:12
1784230 to
cc3209c
Compare
Merged
rafiss
added a commit
that referenced
this pull request
Aug 19, 2026
- Disabled schema_locked by default on connect for CockroachDB v25.3+ and unlocked tables around batched foreign key changes (#404) - Improved error classification by detecting cached plan failures from the error message instead of the source function (#403) - Stopped advertising support for restarting database transactions (#398) - Fixed enum columns being misdetected as spatial columns (#396) Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an enum name contained a spatial type
name (e.g. "point"). It would be matched
by a regex as a sql type. This commit is
handling that by checking type metadata.
See rgeo/activerecord-postgis-adapter#432