Skip to content

fix: creates by template tag, the envd-proxy smoke's node token, the chart's token requirement - #82

Merged
CMGS merged 4 commits into
masterfrom
fix/template-tag-create
Sep 28, 2026
Merged

CMGS merged 4 commits into
masterfrom
fix/template-tag-create

Conversation

@CMGS

@CMGS CMGS commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Four commits on master 85dd5ea:

  • fix(e2bcompat): a create may name a built template by one of its tags. Template.build stores app:v1 as app with tag v1, but the create path handed the whole app:v1 to resolveTemplate, which indexes bare names, so every tagged reference answered 404 (P2 from CMGS, also reported by Codex). name:tag now resolves to the template when the tag is one of its live tags, name:default to the current build; an unknown tag or one whose digest no holder reports stays 404. Regression test fails on the old code with template "app:v1" not found. Docs row updated.
  • fix(envdproxysmoke): the harness passes the node token NewServer requires since 40002c8 (-node-token); it exited at once before. Docs command lines updated.
  • fix(helm): the envd proxy's chart requires apiserver.sandboxdToken.secretName when e2b is enabled (the proxy exits without the token); helm lint and a render with the secret pass, a render without it fails with the reason.
  • review(envdproxy): the probe comment follows the code (401 since cut: closing round 2026-09-28 cut-list, promoted fallback opt-in, paused relay message #80).

The first three are cocoonstack-1's docs re-check findings 1–3 plus CMGS's P2; finding 5 is sandbox #262, finding 6 is sandbox #264.

Template.build stores app:v1 as app with the tag v1, but a create handed the whole app:v1 to resolveTemplate, which indexes bare names, so every tagged reference answered 404 and only app worked; name:tag now resolves to the template when the tag is one of its live tags, name:default to the current build.
…ires

Since 40002c8 a signed file URL relays with the node token and NewServer refuses to start without one; the harness never set it and exited at once.
The proxy exits at startup without --sandboxd-token-file, and the chart passed it only when apiserver.sandboxdToken.secretName was set; the render now fails with the reason instead.
A refused admit answers 401 since #80; the comment still said not found.
@CMGS
CMGS merged commit 774a233 into master Sep 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant