fix: creates by template tag, the envd-proxy smoke's node token, the chart's token requirement - #82
Merged
Merged
Conversation
Template.build stores app:v1 as app with the tag v1, but a create handed the whole app:v1 to resolveTemplate, which indexes bare names, so every tagged reference answered 404 and only app worked; name:tag now resolves to the template when the tag is one of its live tags, name:default to the current build.
…ires Since 40002c8 a signed file URL relays with the node token and NewServer refuses to start without one; the harness never set it and exited at once.
The proxy exits at startup without --sandboxd-token-file, and the chart passed it only when apiserver.sandboxdToken.secretName was set; the render now fails with the reason instead.
A refused admit answers 401 since #80; the comment still said not found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four commits on master 85dd5ea:
Template.buildstoresapp:v1asappwith tagv1, but the create path handed the wholeapp:v1toresolveTemplate, which indexes bare names, so every tagged reference answered 404 (P2 from CMGS, also reported by Codex).name:tagnow resolves to the template when the tag is one of its live tags,name:defaultto the current build; an unknown tag or one whose digest no holder reports stays 404. Regression test fails on the old code withtemplate "app:v1" not found. Docs row updated.NewServerrequires since 40002c8 (-node-token); it exited at once before. Docs command lines updated.apiserver.sandboxdToken.secretNamewhen e2b is enabled (the proxy exits without the token);helm lintand a render with the secret pass, a render without it fails with the reason.The first three are cocoonstack-1's docs re-check findings 1–3 plus CMGS's P2; finding 5 is sandbox #262, finding 6 is sandbox #264.