fix(envdsmoke): pick the envd user with the SDK's Basic auth header - #83
Merged
Merged
Conversation
envd reads the user from Authorization: Basic base64(user:), as the e2b SDK sends it; it ignores X-User, so every process ran as root and the user-account step failed on hardware (root, /root) on both e2b-rt and e2b-ci.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
envd takes the process user from
Authorization: Basic base64(user:), which is the header the e2b SDK sends. It ignoresX-User, so every process the smoke started ran as root, and the user-account step failed on hardware:The two
X-Userheaders becomeAuthorization: Basic ….Hardware (
scripts/envd-e2e.sh, sandboxd at sandbox main 7dd89ae6, isolated cocoon root):ENVDSMOKE PASS; e2b-ci (medium,CODE_INTERPRETER=1)ENVDSMOKE PASS, includinginterpreter runs 1+1.Gates:
make lint10×0 issues.,make fmt-checkclean, asl 0 on darwin and linux.