boot: enable fanotify in the guest kernel - #189
Merged
Merged
Conversation
x86_64_defconfig leaves CONFIG_FANOTIFY off, so fanotify_init() returns ENOSYS inside every sandbox and userspace file monitors that rely on it (an OSWorld task's save-file watcher, scanner-style tools) cannot start. Notification-only fanotify is software-only: no boot-time cost and no work without a listener.
Contributor
Author
|
Kernel build evidence: build-boot run https://github.com/cocoonstack/sandbox/actions/runs/34965616560 (this commit on top of #190, since a dispatched build needs that input fix) is green on amd64 and arm64. The amd64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
x86_64_defconfig(the base of the guest kernel, seeboot/Dockerfile) leavesCONFIG_FANOTIFYoff, sofanotify_init()returnsENOSYSinside every sandbox. Userspace file monitors that rely on it cannot start. Seen with an OSWorld task whose anti-cheat save-file watcher opens a fanotify group; probed in a desktop guest on kernel 6.18.37 as root, as a regular user and via sudo:Change
One line in the kernel fragment:
CONFIG_FANOTIFY=y. Notification-only fanotify (noFANOTIFY_ACCESS_PERMISSIONS) is software-only: no boot-time cost, no work without a listener, a few tens of KB of kernel text.Verification
merge_config.shin the boot image build; the CI boot build carries it.FAN_MODIFY|FAN_CLOSE_WRITE) runs its setup to completion.Hot path: none (kernel build-time option).