Skip to content

#176: fix transaction CSV export handling and empty state columns #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhumiii22 wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −4
Open

#176: fix transaction CSV export handling and empty state columns #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions backend/controllers/transactionController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,8 @@ const deleteCategory = async (req, res) => {

const exportTransactions = async (req, res) => {
try {
const transactions = await IncomeExpense.find({ user: req.user._id, isDeleted: false }).lean();
const userId = req.user._id || req.user.id;
const transactions = await IncomeExpense.find({ user: userId, isDeleted: false }).lean();

const csvData = transactions.map(({ _id, user, name, category, cost, addedOn, isIncome }) => ({
id: _id,
Expand All @@ -354,8 +355,11 @@ const exportTransactions = async (req, res) => {
isIncome,
}));

// Use Papa.unparse directly
const csv = Papa.unparse(csvData, { header: true });
// Use Papa.unparse directly with explicit columns for reliability even on empty datasets
const csv = Papa.unparse(csvData, {
header: true,
columns: ['id', 'user', 'name', 'category', 'cost', 'addedOn', 'isIncome'],
});

res.setHeader('Content-Type', 'text/csv');
res.setHeader('Content-Disposition', 'attachment; filename="paisable_transactions.csv"');
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/utils/transactions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ export const handleExportCSV = async () => {
const res = await api.get('/transactions/export', {
responseType: 'blob', // Important for file download
});
const blob = new Blob([res.data], { type: 'text/csv' });
const blobData = res.data instanceof Blob ? res.data : new Blob([res.data], { type: 'text/csv;charset=utf-8;' });
const blob = new Blob([blobData], { type: 'text/csv;charset=utf-8;' });
const url = window.URL.createObjectURL(blob);
const a = document.createElement('a');
a.href = url;
Expand Down