Ta Modal ut av beta - #1865
Merged
Merged
Conversation
Remove the UNSAFE_ prefix from Modal, Dialog and DialogTrigger and their props types, signalling that the API is stable across versions. The internal _ModalButtonContextReset helper is left untouched and stays out of the package's public API, so the ButtonContext slot limitation it works around can still be solved without a breaking change. AB#130235 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 2afa5b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
oscarcarlstrom
marked this pull request as ready for review
August 26, 2026 12:21
aulonm
approved these changes
Aug 26, 2026
Contributor
Author
|
Merget av Claude Code etter approve fra @aulonm. ✅ (Skrevet av Claude Code, kvalitetssikret av Oscar Carlström — kan være manuelt redigert.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oppsummering
Tar
Modalut av beta ved å fjerneUNSAFE_-prefikset fraModal,DialogogDialogTrigger(og props-typene deres), slik at konsumenter vet at API-et ikke endres mellom versjoner. Løser AB#130235.Blokkeren AB#142627 (Header/Footer i Modal og Drawer) er merget i #1823.
Drawerblir liggende i beta som før.Endringer
UNSAFE_-prefikset ipackages/react/src/modal/modal.tsxogpackages/react/src/modal/index.tsx.modal.stories.tsxogdrawer.stories.tsx.minor) med migreringseksempel.fullscreen-propen blir med ut av beta som den er — den vises allerede i props-tabellen på docs-siden, så å holde den tilbake ville vært en regresjon for de som har tatt den i bruk.Teamet har landet på å la
ButtonContext-begrensningen ligge:Dialogtillater bareslot="close", så en Carousel inne i en modal må nulle ut konteksten via den interne hjelperen_ModalButtonContextResetfor å få sine egneprev/next-knapper. Melder behovet seg, eksponerer vi en Provider for det senere. Det blir en ny komponent, ikke en endring av API-et som nå blir stabilt, og blokkerer derfor ikke beta-exit.Ingen visuelle endringer: dette er bare navnebytte på eksporter. Ingenting i
apps/docs-koden peker på Modal-eksportene.Gjenstår
/komponenter/modal; rette de to kjørbare kodeeksemplene som brukerUNSAFE_DialogTrigger,UNSAFE_ModalogUNSAFE_Dialog; og dokumentere atDialogsetter sin egenButtonContext, som må overstyres om man trenger knapper med en annen slot ennclose.UNSAFE_Modal(mitt-bygg-app, mitt-bygg-selvbefaring, medlem-julekalender, minside-frontend, obosnett-minside, medlem-frontend). De kan først lages når ny versjon er publisert til npm.