Repository navigation
V11.0.0/double digits - #36
Open
gimlichael wants to merge 15 commits into
Open
gimlichael wants to merge 15 commits into
gimlichael wants to merge 15 commits into
Conversation
Packages now target net11.0 and net10.0 instead of net10.0 and net9.0. Consumers still on .NET 9 must stay on the 10.x line.
Moves the central package version of Codebelt.Coverlet.MTP from 10.1.0 to the latest stable 10.1.1 release.
Lets build, pack, test, SonarCloud and CodeQL jobs use the .NET 11 preview SDK while keeping the existing OS and architecture matrix.
The service update now reuses a pending TBD release, preserves its notes without duplicate blocks and writes package configuration as explicit UTF-8.
Availability notes, contributor guidance, the project overview and the READMEs now describe .NET 11 and .NET 10 support.
Adds the 11.0.0 entry to the package release notes so NuGet consumers see the target framework change.
Documents the .NET 11 addition, .NET 9 removal and the coverlet update for the pending major release.
The working copy carried byte-order marks and CRLF endings that differ from the committed files. Normalizing them keeps later diffs limited to real changes.
C# namespace declarations are now an error rather than a suggestion, and text files use LF endings so editors and CI agree on line endings.
Refreshes the Cuemon.Core and HangDump package versions and adds SonarAnalyzer.CSharp to library projects for static analysis.
The CI workflow and the test runner environments now target Ubuntu 26.04, and the Docker test environments are split into net10.0 and net11.0 images.
The contributing guide lists the net10.0 and net11.0 Docker test environments with their images.
Removes the benchmark prompt file from the repository.
The bot folder readme now states that it is the one tracked file there, so the rest of the folder's local-only policy is clear to contributors.
These files differ from the committed copies only in line endings. Normalizing them keeps the working tree clean for later changes.
 [Medium impact] The PR changes package framework support and the release workflows for this library. Fix the service-update version check before merging so dependency updates can run during release preparation.
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+86
to
+99
| current_parts = tuple(int(part) for part in current_version.split(".")) | ||
| if current_status.upper() == "TBD" and current_parts > (major, minor, patch): | ||
| # Reuse a pending patch, minor or major release without skipping its notes. | ||
| new_version = current_version | ||
| elif current_version == latest_version and current_status.upper() != "TBD": | ||
| # The changelog is at the latest released tag; start the next patch release. | ||
| new_version = next_version | ||
| else: | ||
| print( | ||
| f"::error::CHANGELOG.md starts at {current_version} ({current_status}), " | ||
| f"but the latest stable Git tag is {latest_tag}. Expected either " | ||
| f"[{latest_version}] with a release date or a newer version marked TBD." | ||
| ) | ||
| sys.exit(1) |
There was a problem hiding this comment.
The new version check rejects the release state introduced here. CHANGELOG.md starts with dated version 11.0.0, but the latest stable tag is v10.0.13. Neither accepted branch matches, so an update dispatched before v11.0.0 is tagged exits without updating dependencies or opening a PR.
Accept a newer dated release, or consistently keep pending releases marked TBD. The later changelog step currently replaces TBD with a date too.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/service-update.yml
Line: 86-99
Comment:
**Service updates stop before release**
The new version check rejects the release state introduced here. `CHANGELOG.md` starts with dated version `11.0.0`, but the latest stable tag is `v10.0.13`. Neither accepted branch matches, so an update dispatched before `v11.0.0` is tagged exits without updating dependencies or opening a PR.
Accept a newer dated release, or consistently keep pending releases marked `TBD`. The later changelog step currently replaces `TBD` with a date too.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
| { | ||
| "name": "WSL-Ubuntu", | ||
| "type": "wsl", | ||
| "wslDistribution": "Ubuntu-26.04" |
There was a problem hiding this comment.
wslDistribution now selects Ubuntu-26.04, but the contributor guide still tells contributors to use Ubuntu-24.04. Someone following the guide can install the documented distribution and still lack the one that WSL-Ubuntu launches. Update the guide alongside this setting.
Prompt To Fix With AI
This is a comment left during a code review.
Path: testenvironments.json
Line: 7
Comment:
**WSL setup names wrong distribution**
`wslDistribution` now selects `Ubuntu-26.04`, but the contributor guide still tells contributors to use `Ubuntu-24.04`. Someone following the guide can install the documented distribution and still lack the one that `WSL-Ubuntu` launches. Update the guide alongside this setting.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| ### Changed | ||
|
|
||
| - Updated `Codebelt.Coverlet.MTP` from 10.1.0 to 10.1.1, | ||
| - Enabled preview SDK provisioning for build, pack, tests, SonarCloud and CodeQL without changing the OS and architecture matrix, |
There was a problem hiding this comment.
This entry says the OS matrix is unchanged, but the PR moves Linux builds and tests from Ubuntu 24.04 to Ubuntu 26.04 on both architectures. Name that change instead, so maintainers can correctly trace new Linux-only failures.
Suggested change
| - Enabled preview SDK provisioning for build, pack, tests, SonarCloud and CodeQL without changing the OS and architecture matrix, | |
| - Enabled preview SDK provisioning for build, pack, tests, SonarCloud and CodeQL, and moved Linux runners from Ubuntu 24.04 to Ubuntu 26.04 on both architectures, |
Prompt To Fix With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 21
Comment:
**Release notes hide OS change**
This entry says the OS matrix is unchanged, but the PR moves Linux builds and tests from Ubuntu 24.04 to Ubuntu 26.04 on both architectures. Name that change instead, so maintainers can correctly trace new Linux-only failures.
```suggestion
- Enabled preview SDK provisioning for build, pack, tests, SonarCloud and CodeQL, and moved Linux runners from Ubuntu 24.04 to Ubuntu 26.04 on both architectures,
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 17 17
Lines 627 627
Branches 45 45
=======================================
Hits 626 626
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request prepares the 11.0.0 release line by targeting .NET 11.0 and .NET 10.0, updating dependencies and CI runners, and adding Sonar static analysis to the library. It also normalizes line endings and file encodings across the repository so that later diffs contain only meaningful changes.
Target framework support:
Dependency updates:
Continuous integration:
Documentation:
Repository maintenance: