Repository navigation
V11.0.0/double digits - #40
Open
gimlichael wants to merge 11 commits into
Open
gimlichael wants to merge 11 commits into
gimlichael wants to merge 11 commits into
Conversation
Packages and tests now target .NET 11 and .NET 10 alongside .NET Standard 2.0, so the shared build properties and project TFM overrides must match.
Brings Cuemon, Codebelt.Coverlet.MTP and the HangDump extension to their latest stable releases, keeping central package management current.
The pipeline runs on the new .NET 11 toolchain, which requires preview SDK provisioning, and coverage filters are set explicitly so inferred namespaces do not drop production assemblies.
The service update workflow now reads the latest stable Git tag instead of the changelog, so pending major releases and prerelease triggers are handled safely.
Records the .NET 11 target change, removal of .NET 9 and the dependency upgrades for the 11.0.0 release so consumers can see what changed.
Readmes, contributor guidance, agent instructions and DocFX availability text now list .NET 11 and .NET 10 instead of .NET 9, matching the new target frameworks.
Static analysis via SonarAnalyzer.CSharp catches code smells across the library packages, so the analyzer is pinned centrally and referenced from the shared build props.
File-scoped namespaces are now mandatory per the editorconfig rule, so existing block-scoped files are converted to match.
The test runner image is now selected per target framework, so net10.0 and net11.0 each get their own Docker environment, and WSL moves to Ubuntu 26.04.
The contributing guide lists the frameworks and test environments that the repository currently targets.
Line endings are normalized to LF through gitattributes and the UTF-8 byte order mark is removed, so diffs only show real content changes.
 [Medium impact] The changes reach package compatibility, CI, and release automation for this YAML library suite. Fix the dated pending release check before merging so service updates can run before the release is tagged.
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+86
to
+98
| if current_status.upper() == "TBD" and tuple(map(int, current_version.split("."))) > (major, minor, patch): | ||
| # Reuse the pending release, including a framework-support major release. | ||
| new_version = current_version | ||
| elif current_version == latest_version and current_status.upper() != "TBD": | ||
| # The changelog is at the latest released tag; start the next patch release. | ||
| new_version = next_version | ||
| else: | ||
| print( | ||
| f"::error::CHANGELOG.md starts at {current_version} ({current_status}), " | ||
| f"but the latest stable Git tag is {latest_tag}. Expected either " | ||
| f"[{latest_version}] with a release date or a newer version with TBD." | ||
| ) | ||
| sys.exit(1) |
There was a problem hiding this comment.
The new version check rejects this PR’s own changelog. CHANGELOG.md starts with dated version 11.0.0, but the latest stable tag is v10.1.9. A service update on this checkout, or after merging before tagging, reaches the error branch and stops before updating dependencies or opening a PR.
Mark the pending release as TBD, or allow an untagged dated release to be reused safely.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/service-update.yml
Line: 86-98
Comment:
**Service updates stop before tagging**
The new version check rejects this PR’s own changelog. `CHANGELOG.md` starts with dated version `11.0.0`, but the latest stable tag is `v10.1.9`. A service update on this checkout, or after merging before tagging, reaches the error branch and stops before updating dependencies or opening a PR.
Mark the pending release as `TBD`, or allow an untagged dated release to be reused safely.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
| { | ||
| "name": "WSL-Ubuntu", | ||
| "type": "wsl", | ||
| "wslDistribution": "Ubuntu-26.04" |
There was a problem hiding this comment.
This change selects Ubuntu-26.04, but .github/CONTRIBUTING.md still tells contributors to use Ubuntu-24.04. Someone following the guide may install the wrong distribution and be unable to start the declared test environment. Update the guide alongside this change.
Prompt To Fix With AI
This is a comment left during a code review.
Path: testenvironments.json
Line: 7
Comment:
**WSL setup instructions disagree**
This change selects `Ubuntu-26.04`, but `.github/CONTRIBUTING.md` still tells contributors to use `Ubuntu-24.04`. Someone following the guide may install the wrong distribution and be unable to start the declared test environment. Update the guide alongside this change.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 96.66% 97.38% +0.71%
==========================================
Files 14 18 +4
Lines 450 573 +123
Branches 37 52 +15
==========================================
+ Hits 435 558 +123
Misses 15 15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request retargets the Codebelt.Extensions.YamlDotNet suite to .NET 11 and .NET 10, removes .NET 9 from the build, upgrades central package versions, and converts the sources to file-scoped namespaces with normalized line endings.
Build and packaging:
Source and tests:
Continuous integration:
Documentation: