fix: scan-3 follow-ups — mcp flags, chat flag scope, hook env, cora_search guard, uteke spec - #128
Merged
Merged
Conversation
… scrub, cora_search flag guard, uteke spec truth - tole mcp: --plan-mode now filters the SERVED registry to read-only tools and --on-pretool/--on-posttool error out loudly instead of being silently ignored (scan-3 #9 — global args parsed but unhandled by the mcp subcommand). - chat REPL: dropped_message is scoped per message; previously one drop warned on every later message forever (scan-3 #8). - hooks: hook subprocesses scrub secret-shaped env like every other child spawn (scan-3 #23). - cora_search: leading-dash query guard, mirroring uteke_recall (scan-3 #32). - uteke_document spec no longer advertises title/tags that execute() silently drops (scan-3 #33) — the spec now matches reality.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (description of the change)
Fixes the five scan-3 MAJORs that are regressions from today's merged features (or adjacent surfaces they exposed):
tole mcpnow honors global--plan-mode(serves read-only tools only) and LOUDLY rejects--on-pretool/--on-posttool(server mode pre-authorizes Write tools via--allow; silently ignoring the flags was the bug).dropped_messageis scoped per message; previously set-once-never-reset, so a single drop made every later message warn "NOT recorded" forever.scrub_env_for_child, matching run_command/memory — API keys never reach hook processes.cora_searchrejects queries with a leading-, mirroringuteke_recall's flag-injection guard.uteke_documentspec no longer advertisestitle/tagsthatexecute()silently drops.Why (the problem you're solving)
Full-scan hygiene on the same day's feature burst: the scan sees cross-cutting behavior (subcommand flag handling, flag lifecycle, child-process env) that per-PR diff reviews miss. Each item is a real regression or an exposed gap, verified against source before fixing.
Testing (how you verified this works)
-D warningsclean; cora review: No issues found.tole mcpplan-mode path exercises the sameretain_read_only()core logic unit-tested in feat: plan mode — read-only planning constraint (#109) #112; hooks env scrub shares the exactscrub_env_for_childhelper covered by run_command/memory suites.cora_searchguard mirrors the uteke_recall pattern (existing tests there cover the shape).