fix: scan-3 security/spec surfaces — hooks env, cora_search guard, uteke spec, mcp flags, chat scope - #129
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
… guard, uteke spec truth, mcp plan-mode, chat flag scope - hooks: hook subprocesses scrub secret-shaped env like every other child spawn (scan-3 #23). - cora_search: leading-dash query guard, mirroring uteke_recall (scan-3 #32). - uteke_document spec no longer advertises title/tags that execute() silently drops (scan-3 #33). - tole mcp honors --plan-mode (read-only served registry) and loudly rejects --on-pretool/--on-posttool (scan-3 #9). - chat REPL dropped_message scoped per message (scan-3 #8).
ajianaz
force-pushed
the
fix/scan3-security-specs
branch
from
September 22, 2026 16:31
cf79049 to
36b7758
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (description of the change)
Five scan-3 MAJOR fixes on security/spec surfaces:
scrub_env_for_child, matching run_command/memory: API keys never reach hook processes.-are refused (flag-injection guard), mirroringuteke_recall's existing CodeCora-MAJOR guard.uteke_documentspec no longer advertisestitle/tagsthatexecute()silently drops; the spec now matches reality (title derives from the first#heading).tole mcp(E9: Hardening, cross-build CI, perf, OSS prep #9) — global--plan-modeis honored (served registry filtered to read-only) and--on-pretool/--on-posttoolfail loudly instead of being silently ignored.dropped_messageis scoped per message; previously one drop warned on every later message forever.Why (the problem you're solving)
Scan-3 follow-ups on today's feature burst: secret-leak surface (hooks), tool-argument injection surface (cora_search), tool-spec honesty (uteke_document), subcommand flag correctness (mcp), and REPL flag lifecycle (chat).
Testing (how you verified this works)
-D warningsclean; cora review: No issues found.scrub_env_for_childhelper covered by the run_command/memory suites; the cora_search guard mirrors the uteke_recall pattern; the mcp plan-mode path exercises theretain_read_only()logic unit-tested in feat: plan mode — read-only planning constraint (#109) #112.