fix(dwg): Prevent integer underflow in class count calculation - #33
Merged
Merged
Conversation
The original code calculated `endDataPos = maxClassNum - 499` which caused an unsigned integer underflow when maxClassNum <= 499. For example, with maxClassNum=236 (common in AC1032 files from DWG TrueView), this resulted in endDataPos=4294967033 due to unsigned wraparound. This caused massive memory allocation (80GB+) and effectively infinite loops when parsing certain DWG files. The fix adds a bounds check: endDataPos = (maxClassNum > 499) ? (maxClassNum - 499) : 0 Since classes 0-499 are built-in DWG classes and custom classes only start at 500, files with maxClassNum <= 499 simply have no custom classes to parse. Changes: - dwgreader18.cpp: Add underflow protection - dwgreader21.cpp: Add underflow protection - Add unit tests for the underflow fix - Add integration tests for DWG class parsing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
endDataPosto prevent unsigned integer underflow whenmaxClassNum <= 499Technical Details
The original calculation
endDataPos = maxClassNum - 499caused unsigned integer wraparound whenmaxClassNum <= 499. For example:maxClassNum = 236(common in AC1032 files from DWG TrueView)236 - 499 = 4294967033(unsigned wraparound)(236 > 499) ? (236 - 499) : 0 = 0Since classes 0-499 are reserved built-in DWG classes and custom classes start at 500, files with
maxClassNum <= 499have no custom classes to parse, makingendDataPos = 0the correct value.Testing
🤖 Generated with Claude Code