fix(dwg): Add AC1032 version support and improve shell scripts - #34
Merged
Merged
Conversation
- Add AC1032 (AutoCAD 2018) version check to header and class parsing to correctly handle high-size 32-bit field regardless of maintenance version - Redirect error messages to stderr in dwg2txt and dxf2txt scripts - Improve dwg2txt binary lookup to check installed path before dev path - Add installed lib path to LD_LIBRARY_PATH in dwg2txt - Remove emoji characters from script output messages - Add test_dimensions, test_annotations, and test_attributes test targets Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
|| version >= DRW::AC1032condition to header (drw_header.cpp) and class reader (dwgreader18.cpp) so the high-size 32-bit field is correctly read for AC1032 files regardless of maintenance versiondwg2txt,dxf2txt): Redirected all error/status messages to stderr (>&2) so stdout contains only command output; removed emoji characters for portabilitydwg2txt): Check installed location ($SCRIPT_DIR/dwg2text) before falling back to development path (../dwg2text/.libs/dwg2text); added installed lib path toLD_LIBRARY_PATHMakefile.in): Addedtest_dimensions,test_annotations, andtest_attributesbuild and run targetsTesting
Breaking Changes
Additional Notes