Repository navigation
Conversation
bpmct
marked this pull request as ready for review
November 4, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
coder-labstemplate that runs each workspace in an NVIDIA OpenShell sandbox on Kubernetes. It is the third sibling of agent-sandbox (Kubernetes) (#1230) and Plain Sandbox (Kubernetes) (#1232)./usrand/etcread-only and denies paths outside the policy.kata-qemuorkata-clhinruntimesto offer a microVM. gVisor does not work, because it has no Landlock.build/launcher/Dockerfile, Alpine and theopenshellCLI, 35 MB) creates the sandbox on start and deletes it on stop. Coder owns the home disk, mounted at/sandbox/home.cluster/installs the gateway with the Helm provider and creates the namespaces, the gateway credentials, the RuntimeClass labels, and the RBAC. Itscoder_variablesoutput is the--variables-file.build/Dockerfile, the scoped AI Gateway token, the code-server, git-clone, and Claude Code setup, the presets, and the README layout..icons/openshell.svg, the OpenShell mark fromNVIDIA/OpenShell(Apache-2.0).Startup on EKS, create to connected agent: about 2 s from a prebuild, 14 s cold, 17 s cold on Kata.
Type of Change
Template Information
Path:
registry/coder-labs/templates/kubernetes-openshellTesting & Validation
terraform test: 24 template runs and 5cluster/runs, with mock providers). CI runs.tftest.hclonly for modules, so these do not run in CI.prettier --check,terraform fmt), README validator and shellcheck passLive test results
cluster/apply (a second gateway release)6.18.35example.com,*.wikipedia.org, 443)wikipedia.orgitself blocked/usrand reading/etc/shadowdeniedclaude -panswersDecisions
cluster/copies the CA (for supervisors) and the client bundle (for launchers) across.createin the background, so SIGTERM deletes the sandbox at once, even while a create waits for compute. The old prototype ran it in the foreground, and a stop or a delete during a Pending create left a suspended Sandbox behind.restart_policy = "Always"on the launcher: a restarted launcher replaces the sandbox. A crash costs the running session but not the home, instead of a workspace whose agent never comes back.cpuandmemoryare template variables (1 and 2Gi), because OpenShell sets them as both the request and the limit, and 2 CPU left new sandboxes Pending on a busy cluster.runtime = "none"whenruntimesis set, like feat(registry/coder-labs/templates): add the Plain Sandbox (Kubernetes) template #1232, so a claim never changes an immutable parameter.Review
A Claude (Fable) review found no blockers. Fixed: the Helm provider constraint (
>= 3.0for the attribute syntax), the TERM trap during a create, theopenshell policy updateexample (prettier's sh plugin had mangled it), the Landlock and wildcard wording, the agent token note, a removed redundantcurlrule, and more tests. Not changed: polling for a sandbox that the gateway removes, because a gateway blip would then restart a healthy sandbox.Related Issues
None
🤖 This PR was generated by Coder Agents on behalf of @bpmct.