Repository navigation
🤖 tests: lint scripts tests and vscode/src; fix their findings - #7586
Conversation
…t; fix their findings
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac6dff19a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🟢 e2e stories (Haiku): 14 passed22 agent steps · 7 replayed from cache · 15 model calls · 45.8k tokens (28% cached) All 14 tests in 9 files
e2e 0.20.0 · 1m 16s · web · run artifacts 🟢 e2e Electron stories (Haiku): 3 passed3 agent steps · 3 model calls · 7.9k tokens (33% cached) All 3 tests in 3 files
e2e 0.20.0 · 23.3s · electron · run artifacts 🟢 e2e agent repros (Haiku): no tests selectedSpend: $0.00 of the $1.00 cap (proxy ledger) e2e 0.20.0 · 6.9s · 2 targets (web, phone) · run artifacts |
…ith scripts/mintlify/node_modules)
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…aced typecheck's install)
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fccb6408a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
ESLint and oxlint now lint
scripts/**/*.test.ts(47 files) andvscode/src/**(33 files), and this PR fixes the 163 findings there, including the 13as anyinvscode/src/webview/createVscodeOrpcLink.test.ts.Background
The 2026-10-26 audit found that neither tree was in
LINT_FILE_PATTERNS(scripts/lib/lint_targets.js), so no lint rule reached them, including the mock-restore rule. Both trees are already type-checked throughtsconfig.tooling.json.Implementation
eslint.config.mjs: one block for both trees that lints againsttsconfig.tooling.json(the project service would picktsconfig.json, which does not include them), with the same base rules andno-unused-varsoptions astests/. Two smaller blocks: the React hook rules forvscode/src/**/*.tsx, and thetests/relaxations (require-await,no-empty-functionoff) for test files only..oxlintrc.jsonmirrors those three blocks.make check-oxlint-configpasses.scripts/lint.shESLINT_PATTERNS,LINT_FILE_PATTERNSand the oxlint roots (scripts,vscode/src) include the two trees.eslint --fixfor the stylistic rules, then real types where possible (getLastSentreturns the typed message,JSON.parseresults useDryReport/MutateReport, a declaredacquireVsCodeApireplaces a@ts-ignore). Inline disables carry a reason:await-thenablefor bun:testexpect().rejects(the header 7 src tests already use),no-control-regexin 4 output-sanitizing assertions, and 4 single sites (AsyncIterator.return(), a last-resortString(data), an empty-trace-id||, and thevscodemodule mock, which has no real module to restore under bun).vscode/srcis unchanged.extension.tskeeps the empty-string-clears-selection rule explicitly, andApp.tsxonly moves a comment so no comment sits between twocaselabels.Validation
make lint-full(every file): passes.make typecheck,bun test ./vscode/src/(163 pass, 1 skip) andbun test ./scripts/(563 pass) pass.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high