Repository navigation
🤖 refactor: delete unreferenced type aliases and re-exports in node/common - #7600
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
1a67902 to
f5119bc
Compare
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🟢 e2e stories (Haiku): 14 passed22 agent steps · 7 replayed from cache · 15 model calls · 45.8k tokens (28% cached) All 14 tests in 9 files
e2e 0.20.0 · 1m 16s · web · run artifacts 🟢 e2e Electron stories (Haiku): 3 passed3 agent steps · 3 model calls · 8.0k tokens (32% cached) All 3 tests in 3 files
e2e 0.20.0 · 18.3s · electron · run artifacts 🟢 e2e agent repros (Haiku): no tests selectedSpend: $0.00 of the $1.00 cap (proxy ledger) e2e 0.20.0 · 5.3s · 2 targets (web, phone) · run artifacts |
…ommon Delete the z.infer aliases, interfaces and re-exports that no file references (found by check-test-only-exports, #7561), and the SessionTapeLineSchema only one of them used. Tests that typed fixtures with a test-only alias now use the production type.
f5119bc to
d947d8f
Compare
Summary
Delete the type aliases, interfaces and re-exports in node/common that nothing references. P3-2's new check (
check-test-only-exports, #7561) lists each of them inpendingDeletionfor this workstream.Deleted (no file imports them. Most hits for these names are other declarations with the same name):
z.inferaliases:AgentPluginInstallSource(and its unused re-export fromappConfigOnDisk.ts),AnthropicSpeed,FastModePreviousServiceTier,ThemePreferenceConfig,RawQueryColumnandRawQueryResult(analytics.ts;queries.tsdeclares its own),ArtifactVersionSource,SkillsCliCommand,RuntimeEnablementOverrides(and its unused re-export),EvaluationInput,EvaluationProviderOptions,SessionTapeEventLine,SessionTapeLine(andSessionTapeLineSchema, which only that alias used), the threeAutoRetry*Eventaliases instream.ts(retryManager.tsdeclares the ones production uses),StatusUpdateToolArgs,PlanReviewSnapshotRecord,PlanReviewFeedbackReply,PlanReviewThreadReplyandMappedCodexHookEvent.PersistedKeyScope, and the localStorage-eraReviewStateandReviewsStateinterfaces intypes/review.ts. The DI tagReviewStateandChatPane's localReviewsStateare other declarations.CLAUDE_DESIGN_SERVER_NAMEfromclaudeDesignService.ts(callers import@/common/constants/claudeDesign), andAskUserQuestionOptionSchemafromtoolDefinitions.ts.Test-only aliases. Each test now types its fixture with the production type:
ProviderModelEntry(providerModelEntry.ts):coderOauthService.test.tsimports the@/common/orpc/typesone, like every other caller.AWSCredentialStatus(orpc/types.ts):api.test.tsusesProviderConfigInfo["aws"].PlanReviewFeedbackComment:prepareFeedback.test.tsusesPlanReviewFeedbackRecord["comments"].Validation
make typecheckandmake lint-eslintpass. The touched suites pass (415 tests). I ran P3-2's checker from #7561 against this stack, and it reports every deleted entry as stale and nothing new.Part of test-audit phase 3, workstream P3-3.
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high