[ThomasK33]

Summary

Deletes eight browser exports that only tests called, plus two story helpers that nothing calls. The tests now go through the code that production runs. No app behavior changes.

Background

#7561 (P3-2) adds check-test-only-exports and lists these symbols under pendingDeletion with owner P3-4 (frontend test audit). This PR clears every P3-4 entry except DraftAttachmentMatchesChatAttachment (see below).

Export	Why it was dead	What the test does now
GoalsSection	Settings never mounts it. Only its child GoalDefaultsControls ships (in GoalDefaultsSection).	Renders GoalDefaultsControls, the same inputs.
highlightDiffChunk	One-chunk wrapper. DiffRenderer calls highlightDiffChunks.	A local helper calls highlightDiffChunks([chunk]) and asserts one result.
migrateWorkspaceStorage	#6620 removed its last caller.	Its two tests guarded only its own "keep the source on failure" branch, so they go with it.
getSuggestedModels, calculateTPS, calculateTokenCount, DeltaRecord, filterWorkflowDisplayOnlyMessages	Browser re-exports of @/common functions that only tests imported.	Tests import from the @/common module directly.
textContrastOnBase, opaqueBackgroundOwner (story helpers)	#6978 removed their only caller, the project-badge story.	None.

DraftAttachmentMatchesChatAttachment stays: it is a compile-time drift check. Without export, noUnusedLocals and no-unused-vars both reject it, so #7561 needs to move it to allowed.

Validation

• I ran 🤖 tests: fail on production exports that only tests (or nothing) reference #7561's checker (scripts/check-test-only-exports.ts at f8d1727) on this tree. It reports all eight targeted entries as stale, which means they are gone.
• The six touched test files pass (92 tests). make static-check and make crap-check pass.

---

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $36.68

[ThomasK33]

@codex review

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T14:39:51.918046Z	0ca38c7	Manual request
🔒 Security Review	✅ Completed 2026-10-26T14:40:22.607514Z	0ca38c7	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 0ca38c7952

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 0ca38c7952

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

• You comment "@codex security review"
• A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

[github-actions]

🟢 e2e stories (Haiku): 14 passed

22 agent steps · 7 replayed from cache · 15 model calls · 46.2k tokens (26% cached)
Spend: $0.09 of the $1.00 cap (proxy ledger)

All 14 tests in 9 files

	Test	Agent	Time
🟢	chatRestart.e2e.ts · 1 passed	1 step · 1 call	5.4s
🟢	a chat survives a restart of the server	1 step · 1 call	5.4s
🟢	compaction.e2e.ts · 1 passed	1 step · 1 call	4.3s
🟢	/compact replaces the old chat with a summary	1 step · 1 call	4.3s
🟢	pluginTrustRestart.e2e.ts · 1 passed	4 steps · 2 calls	9.5s
🟢	a trusted plugin hook stays trusted after the server restarts	4 steps · 2 calls	9.5s
🟢	settingsRoundTrip.e2e.ts · 1 passed	2 steps · 1 call	8.8s
🟢	a chat survives trips through Settings	2 steps · 1 call	8.8s
🟢	sidebarPerWorkspace.e2e.ts · 1 passed	4 steps · 1 call	4.0s
🟢	a new workspace starts with its right sidebar collapsed while another keeps it open	4 steps · 1 call	4.0s
🟢	smoke.e2e.ts · 1 passed	2 steps · 1 call	3.1s
🟢	the agent opens the playground workspace	2 steps · 1 call	3.1s
🟢	streamErrors.e2e.ts · 1 passed	1 step · 1 call	6.8s
🟢	stream errors show in the chat, and the chat recovers	1 step · 1 call	6.8s
🟢	todoNudge.e2e.ts · 1 passed	1 step · 1 call	2.7s
🟢	the agent finishes open TODO items after the turn-end nudge	1 step · 1 call	2.7s
🟢	touchAlignment.e2e.ts · 6 passed	6 steps · 6 calls	21.7s
🟢	the Settings close button is level with the title on a touch screen 390px wide	1 step · 1 call	4.1s
🟢	the Settings close button is level with the title on a touch screen 768px wide	1 step · 1 call	3.3s
🟢	Backup settings checkboxes are small and level with their labels on a touch phone	1 step · 1 call	4.8s
🟢	the heartbeat checkbox is small and level with its label on a touch phone	1 step · 1 call	3.4s
🟢	a reply's model and time stay on one line on a touch phone	1 step · 1 call	3.3s
🟢	the workspace actions menu stays on the title row on a touch phone	1 step · 1 call	2.7s

_{e2e 0.20.0 · 1m 9s · web · run artifacts}

🟢 e2e Electron stories (Haiku): 3 passed

3 agent steps · 3 model calls · 7.9k tokens (22% cached)
Spend: $0.02 of the $1.00 cap (proxy ledger)

All 3 tests in 3 files

	Test	Agent	Time
🟢	electron/deepLink.e2e.ts · 1 passed	1 step · 1 call	6.2s
🟢	a deep link of a second launch starts a chat in the running app	1 step · 1 call	6.2s
🟢	electron/menuBar.e2e.ts · 1 passed	1 step · 1 call	5.8s
🟢	the workspace menu bar is the desktop title bar	1 step · 1 call	5.8s
🟢	electron/smoke.e2e.ts · 1 passed	1 step · 1 call	4.7s
🟢	Xum Electron opens the playground workspace	1 step · 1 call	4.7s

_{e2e 0.20.0 · 18.7s · electron · run artifacts}

🟢 e2e agent repros (Haiku): no tests selected

Spend: $0.00 of the $1.00 cap (proxy ledger)

_{e2e 0.20.0 · 5.3s · 2 targets (web, phone) · run artifacts}