Skip to content

🤖 fix: keep Geist Mono's 1.5.1 vertical metrics so the phone static view stays the LCP #7638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasK33 merged 1 commit into from
Oct 26, 2026
Merged

🤖 fix: keep Geist Mono's 1.5.1 vertical metrics so the phone static view stays the LCP #7638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/browser/styles/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@
font-weight: 100 900;
font-style: normal;
font-display: swap;
/* The vertical metrics of geist 1.5.1's Geist Mono. geist 1.8.1 raised them from 955/245 to
1005/295 units (a 1.3 em text box, was 1.2 em; the baseline stays where it was). The phone
static workspace view paints code before this font loads (no preload, see staticAssets.ts), so
the live code line's taller box was a new, later LCP entry: seeded phone Lighthouse 93 -> 70
(#7637). Keep the live box no larger than the static copy's. */
ascent-override: 95.5%;
descent-override: 24.5%;
line-gap-override: 0%;
}

@import "./theme-dark.css";
Expand Down
Loading