Skip to content

🤖 refactor: move terminal attention scheduling into TerminalAttentionNotifier #7669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasK33 merged 1 commit into from
Oct 27, 2026
Merged

🤖 refactor: move terminal attention scheduling into TerminalAttentionNotifier #7669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/node/services/taskService.shared.testHarness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,8 +422,10 @@ export async function flushTerminalAttentionDrains(
assert(passes > 0, "flushTerminalAttentionDrains needs at least one pass");
for (let i = 0; i < passes; i++) {
const drains = (
taskService as unknown as { pendingTerminalAttentionDrains: Set<Promise<void>> }
).pendingTerminalAttentionDrains;
taskService as unknown as {
terminalAttention: { pendingTerminalAttentionDrains: Set<Promise<void>> };
}
).terminalAttention.pendingTerminalAttentionDrains;
if (drains.size === 0) break;
await Promise.all([...drains]);
}
Expand Down
9 changes: 5 additions & 4 deletions src/node/services/taskService.terminalAttentionIdleWait.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,11 @@ describe("TaskService terminal attention idle waits", () => {
const chatListeners = () => emitter.listenerCount("chat-event");
const baseline = chatListeners();

const drainChains = Reflect.get(taskService, "pendingTerminalAttentionDrainsByOwner") as Map<
string,
Promise<void>
>;
const drainChains = (
taskService as unknown as {
terminalAttention: { pendingTerminalAttentionDrainsByOwner: Map<string, Promise<void>> };
}
).terminalAttention.pendingTerminalAttentionDrainsByOwner;

for (const [index, childId] of childIds.entries()) {
const reportMarkdown = `Report ${index} from ${childId}`;
Expand Down
Loading
Loading