Repository navigation
Scenario: a new method is added, but there's no test for it - #1
Open
adamtornhill wants to merge 12 commits into
Open
adamtornhill wants to merge 12 commits into
adamtornhill wants to merge 12 commits into
Conversation
adamtornhill
changed the title
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Code Coverage Gate Failed
Gates Failed
(required = 80%)
(required = 95%)
Review details by gate
| Gate | Pass/Fail Reason | Action |
|---|---|---|
| Overall Coverage | The overall coverage gate was checked for all code in src/main/java/ and is too small: 70.0% covered < threshold = 80% | Start by adding tests to the following files: src/main/java/com/codescene/ConditionalExample.java : 9 uncovered lines,src/main/java/com/codescene/Calculator.java : 3 uncovered lines. Optionally, exclude content from the coverage gates via CodeScene's configuration. |
| New & Changed Code Coverage | New or changed code lacks code coverage: 0.0% covered < threshold = 95% | Add tests to: src/main/java/com/codescene/Calculator.java : uncovered lines = 43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR illustrates the example of new code being written without any coverage at all. (It's dead code in this case).
We expect the code coverage gate to fail, letting us know that
0 %of the new code has coverage.