Repository navigation
Fix project matching for SSH host aliases - #361
Merged
Merged
Conversation
Resolve SSH hosts through OpenSSH user configuration before building repository identities. Cover alias matching and invalid-config fallback with end-to-end tests, and document the behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add unit coverage for alias normalization, missing and inaccessible config, malformed output, unavailable SSH, command failure, and timeouts. Isolate command execution for deterministic failure-path tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Honor USERPROFILE for Windows SSH config discovery and normalize Include paths. Build Docker e2e images with the runner UID/GID so OpenSSH can resolve its local passwd entry. Add a Windows home override regression test and include server diagnostics in matching failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Code Coverage Gates Passed
Overall Coverage: 98.5%
(required = 95%)
New & Changed Code Coverage: 99.6%
(required = 95%)
Review details by gate
-
Overall Coverage
- Pass/Fail Reason:
The overall coverage gate was checked for all code in npm/, vscode/ and meets the goal: 98.5% covered >= threshold = 95% - Action:
You have 84 files with a sum of 17386 covered and 267 uncovered lines of code.
- Pass/Fail Reason:
-
New & Changed Code Coverage
- Pass/Fail Reason:
New or changed code meets coverage goal: 99.6% covered >= threshold = 95% - Action:
You modified 5 files, and covered 226 added/modified lines of code.
- Pass/Fail Reason:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression coverage
The new end-to-end regression test returned empty project IDs before the fix and now resolves the expected IDs. Coverage includes SCP-style, ssh:// and git+ssh:// remotes, included config, wildcard and user-specific rules, Azure normalization, unchanged HTTPS handling, and invalid-config fallback.
Validation