Repository navigation
Conversation
These tests read the terminal environment the suite runs in, and fail in common setups that CI never has: - inside tmux or GNU screen, or in Tilix or Terminator (TMUX, STY, TILIX_ID or TERMINATOR_UUID set), apply_env_overrides caps the redraw rate. The two Ghostty tests in settings and config_fancy_animations_keeps_ghostty_full_motion assert it is not capped, so they fail there. They already remove the SSH markers for the same reason; the sibling tests no_animations_* and other_terminals_* already remove these four as well. - over SSH (SSH_CLIENT, SSH_CONNECTION or SSH_TTY set) the clipboard export goes to the terminal client and says so, and command_clipboard_export_preserves_structure_and_redacts_secrets expects "local clipboard". - with NO_ANIMATIONS=1 exported, the two Ghostty tests, non_vscode_term_program_does_not_force_low_motion and tilix_and_terminator_cap_redraws_without_disabling_motion fail because motion is switched off before they look at it. Each test now removes those variables for its own duration with EnvVarGuard, under the env lock it already holds. Production code is unchanged. Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Hmbown
approved these changes
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Six tui tests read the terminal environment the suite runs in and fail in setups CI never has:
TMUX,STY,TILIX_IDorTERMINATOR_UUIDset),apply_env_overridescaps the redraw rate. The two Ghostty tests insettingsandconfig_fancy_animations_keeps_ghostty_full_motionassert it is not capped. They already remove the SSH markers for the same reason, and the siblingno_animations_*/other_terminals_*tests already remove these four.SSH_CLIENT,SSH_CONNECTIONorSSH_TTYset) the clipboard export goes to the terminal client and says so, whilecommand_clipboard_export_preserves_structure_and_redacts_secretsexpects "local clipboard". The clipboard target is picked whenAppis built, so the export harness removes the three variables before it builds the app, not inside the test.NO_ANIMATIONS=1exported, the two Ghostty tests,non_vscode_term_program_does_not_force_low_motionandtilix_and_terminator_cap_redraws_without_disabling_motionfail because motion is already off.Each test now removes those variables for its own duration with
EnvVarGuard, under the env lock it already holds. Production code is unchanged.#6973 moves
config_fancy_animations_keeps_ghostty_full_motionintoconfig_main_host.rs. Whichever of the two lands second needs the fourEnvVarGuard::removelines carried over to the test's new place.Issue
No-Issue: local test failures only, no issue filed for them
How I tested it
TMUX,STY,TILIX_IDorTERMINATOR_UUIDfails the three Ghostty tests, any one of the SSH variables fails the export test,NO_ANIMATIONS=1fails four. After: all six pass in every case, and also with tmux, iTerm, SSH andNO_COLORset together.cargo fmt --all -- --check,cargo clippy -p codewhale-tui --all-targets --all-featureswith CI's flags, andcargo check -p codewhale-tui --all-targets: clean. Clippy also on 1.99, pluscargo +1.89.0 check -p codewhale-tui.cargo nextest run -p codewhale-tui --lib: 15289 passed, none failed.No new tests; this changes six existing ones and the export test harness.
Checklist
maincargo fmt --allpasses, and tests cover new or changed behaviordocs/features.toml(cargo test -p codewhale-tui --test feature_registrychecks it) — n/a