Repository navigation
Conversation
active_participant_rejects_new_and_exact_replay_without_blocking_or_starting gives each apply_prompt call 1 s to come back with "active local provider work". Before it refuses, apply_prompt creates the native thread, writes the binding and a turn reservation to disk with write_atomic, and then writes the reservation's release. On windows-latest the whole test normally takes 0.2-0.4 s, but it took 1.1-3.8 s in 5 of 18 passing runs since 10-13, and on main at a8e3281 one call went past the second: Runtime Chat admission must not deadlock behind the UI-owned writer: Elapsed(()) The refusal itself never waits: try_ensure_inference_ownership only tries to take the lease. The bound is there to catch a deadlock, and 30 s still does. It is the same 30 s bound the subagent approval tests use for the same kind of check. Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
runtime_chat_relay::tests::active_participant_rejects_new_and_exact_replay_without_blocking_or_startingfailed on windows-latest on main at a8e3281:The test gives each
apply_promptcall 1 s to come back with "active local provider work". Before it refuses,apply_promptcreates the native thread, writes the binding and a turn reservation to disk withwrite_atomic, and then writes the reservation's release. On windows-latest the whole test usually takes 0.2-0.4 s, but in 5 of 18 passing runs since 10-13 it took 1.1-3.8 s (it passed in 3.76 s on https://github.com/codewhale-hq/Codewhale/actions/runs/38433637142, for example), so the 1 s bound has very little room left.The refusal itself never waits:
try_ensure_inference_ownershiponly tries to take the lease. The bound is there to catch a deadlock, and 30 s still does. That is the same 30 s bound the subagent approval tests use for the same kind of check (#6966).Issue
No-Issue: Windows CI flake, no issue filed for it
How I tested it
F_FULLFSYNC, so the test's own syncs wait behind them. With the 1 s bound, 22 of 43 runs failed with theElapsed(())above (the test took 2.1-6.3 s). With 30 s, none of 101 runs failed (2.6-4.0 s). On an idle machine both pass in about 0.1 s.cargo fmt --all -- --check,cargo clippy -p codewhale-tui --all-targets --all-featureswith CI's flags, andcargo check -p codewhale-tui --all-targets: clean. Clippy also on 1.99, pluscargo +1.89.0 check -p codewhale-tui.cargo nextest run -p codewhale-tui --lib: 15304 passed, none failed.No new tests; this changes one bound in an existing one.
Checklist
maincargo fmt --allpasses, and tests cover new or changed behaviordocs/features.toml(cargo test -p codewhale-tui --test feature_registrychecks it) — n/a