[CDF-28463] Map Observation startTime from node.createdTime in infield-data migration - #3146
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the view-to-view mapping logic to support mapping a single source property to multiple destination properties. The container_mapping attribute now accepts a list of strings, and the conversion logic has been updated to iterate over all mapped destination properties. Unit tests and configuration examples have been added to verify this new behavior. I have no feedback to provide as the changes are well-implemented and fully tested.
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3146 +/- ##
=======================================
Coverage 86.13% 86.14%
=======================================
Files 481 481
Lines 44870 44877 +7
=======================================
+ Hits 38648 38658 +10
+ Misses 6222 6219 -3
🚀 New features to boost your workflow:
|
Description
View-to-view
containerMappingcan now map one source property to multiple destination properties. Subsequently used bycdf migrate infield-datasuch that Observationnode.createdTimeis now written to bothsourceCreatedTimeandstartTime("Observed At") since the same source property as the bext proxy for both targets.Bump
Changelog
Improved
cdf migrate infield-data, FieldObservation will now have it'sstartTime/Observed Atproperty populated based on the source Observation instance by default..