Skip to content

[CDF-28751] 🦪 Ty on DataIO classes - #3434

Merged
doctrino merged 9 commits into
mainfrom
more-ty
Oct 20, 2026
Merged

doctrino merged 9 commits into
mainfrom
more-ty

Conversation

@doctrino

@doctrino doctrino commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Description

Run ty on test_dataio in addition renamed test_storageio -> test_dataio.

Bump

  • Patch
  • Skip

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@doctrino
doctrino marked this pull request as ready for review October 20, 2026 10:23
@doctrino
doctrino requested review from a team as code owners October 20, 2026 10:23
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
44698 37972 85% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/dataio/_applications.py 81% 🟢
TOTAL 81% 🟢

updated for commit: ef67052 by action🐍

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.95%. Comparing base (a332612) to head (ef67052).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3434      +/-   ##
==========================================
- Coverage   85.58%   84.95%   -0.64%     
==========================================
  Files         471      471              
  Lines       46659    44698    -1961     
==========================================
- Hits        39934    37972    -1962     
- Misses       6725     6726       +1     
Files with missing lines Coverage Δ
cognite_toolkit/_cdf_tk/dataio/_applications.py 80.59% <100.00%> (ø)

... and 203 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@doctrino
doctrino enabled auto-merge (squash) October 20, 2026 10:34
@doctrino

Copy link
Copy Markdown
Contributor Author

/gemini review

@doctrino doctrino changed the title [CDF-28751] 🦪 Ty on partly DataIO classes [CDF-28751] 🦪 Ty on DataIO classes Oct 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces type-checking stubs for httpx and httpcore to support static analysis when aliasing to httpx2 and httpcore2 at runtime. It also refactors various tests to use .model_validate() for Pydantic models, replaces list with Sequence in dataio signatures for better type flexibility, and centralizes the CDF_CLUSTER constant. There are no review comments to address, and I have no additional feedback to provide.

@doctrino
doctrino merged commit 017721d into main Oct 20, 2026
16 checks passed
@doctrino
doctrino deleted the more-ty branch October 20, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants