Repository navigation
Simplify the tool surface and add meal ratings - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
rate_mealso members can submit or edit a 1–5 meal rating, reasons, comments, and per-rating preferences through the existing preview and confirmation gate. Ratings target an exact owned piece, preserve omitted feedback and existing attachments, and include historical lookup arguments when an outcome is uncertain. Delivery lists and status responses now show owned rating feedback. Historical lookups accept bothfromandto, score-change previews show the old and new score, and reason normalization preserves unknown server codes while removing known incompatible codes and duplicates.Removes
skip_deliveryandexplain_pick, bringing the server to 11 tools. Skipping useslist_deliveriesplusremove_meal; recommendations replace pick comparisons without preserving exact ranks outside the returned suggestions. Deletes unused configuration, result-conversion, transport, selection, and timestamp code, trims GraphQL selections, and shares ownership filtering so a missing user ID never claims another member's meal. Keeps the 20-minute keepalive and existing mutation recovery safeguards.Validation:
bun run check: lint, formatting, type checking, and 226 tests passing in each timezone run.bun run smoke: packaged installs pass with both Bun and Node, each exposing the expected 11 tools and rating schema.Buffet ratings, photo editing, and account-setting changes are not included.
The live rating check showed that Forkable can enable rating follow-ups when the prior preference is unreported and the argument is omitted. The preview and documentation now label that as Forkable’s default rather than claiming the preference stays unchanged. Feedback-clearing and existing-photo preservation remain covered by mocked tests only.