Repository navigation
Conversation
Inline comments are comment nodes, but `textContent()` and the text walkers in the `toc` and `title-description` plugins still collected their body. The comment text ended up in heading ids, toc link text, `meta.title` and `meta.description`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Architecture Data flow Review ✨ Nothing flagged · reviewed Tip The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change 🪧 More tips
Thanks for using PR Lens! It's free for OSS. If it helped, a star helps other teams find it. |
Documentation previewsPreviews are disabled for pull requests from forks. |
|
@aliassar is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
comark
@comark/angular
@comark/ansi
@comark/html
@comark/nuxt
@comark/react
@comark/svelte
@comark/vue
commit: |
What
textContent()and the text walkers in thetocandtitle-descriptionplugins now skip comment nodes, so an inline<!-- ... -->no longer ends up in heading ids, toc link text,meta.titleormeta.description. The plugins keep their own walkers, because they also drop the separateheading-linkslink andtextContent()doesn't, so each one gets the samenode[0] === nullcheck instead.Why
Inline comments have been comment nodes since #401 and stay hidden, but their text still leaked into anything built from text content, and #409 says heading slugs should come from visible text only. That puts things like internal TODOs into public anchors and page titles. Headings with an inline comment get a new id (
install-todo-link-guidebecomesinstall-guide), and text around a comment keeps its spaces (Install guide), the same as around an image.Checks:
pnpm run lint,pnpm run typecheck, thecomark, html, ansi, vue and React server tests, and the bundle snapshot (unchanged). The React/Svelte browser tests didn't run here because Chromium isn't installed.Repro:
Summary by CodeRabbit