[don-petry]

Problem

Stale-disposition retry cap does not count a fix-reviews pass that dies before posting any marker (follow-up to the edited-comment deadlock fix)

From the issue: The stale-disposition retry cap added for #2166 (PR #2230) bounds how many fix-reviews passes the sweep dispatches for a bot comment that was edited after its disposition. It counts passes by their markers on the PR: any <!-- dev-lead-fix-reviews pr=<n> … intent=fix-reviews status=… --> comment newer than the edit.

Risk

Low — changes automation shell logic under scripts/, covered by shellcheck (--severity=warning) and the bats suite.

Test plan

Tests added/updated: tests/dev-lead/unit/test_dev_lead_retry.bats,tests/dev-lead/unit/test_fix_reviews.bats tests/dev-lead/unit/test_maintainer_comment_gate.bats. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

This PR's Lint (shellcheck) and bats checks show pass/fail; watch subsequent dev-lead / pr-review runs for behavioral regressions.

Closes #2247

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to post a start marker (<!-- dev-lead-fix-reviews-start ... -->) before a fix-reviews pass runs. This ensures that passes that fail or die prematurely (before posting a terminal marker) are still counted towards the stale disposition retry cap. The retry logic is updated to count these start markers, grouping them with terminal markers by their read_at timestamp to avoid double-counting. Unit tests are added to verify the new behavior and ensure the start marker is treated as a registered automation marker. I have no feedback to provide as there are no review comments.

[don-petry]

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

[codeant-ai]

CodeAnt Nitpicks

1 code suggestion

1. If separate passes start in the same second, they reuse read_at; the sweep counts them as one attempt, allowing failures to exceed the retry cap.

Logic error · scripts/dev-lead-fix-reviews.sh:936

[don-petry]

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

Issues addressed: 0
- CodeAnt neutral overview (PR Risk: Low Risk): No actionable findings — dispositioned informational
Files changed: none
Skipped (informational): 1
```
The bot comment is a neutral overview describing the PR as safe to merge with good test coverage. Per the maintainer-comment gate requirements, I posted an `informational` disposition reply on the original comment (ID: `IC_kwDOR9SdIs8AAAABbDtF2A`) to clear the gate blocker. No code changes were needed.

[don-petry]

No description provided.

[don-petry]

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

## Summary
**Bot:** coderabbitai[bot]
**Issues addressed:** 0 (no code findings)
**Disposition:** Rate-limit notice → posted `informational` disposition
The CodeRabbit comment is a **pure rate-limit notice** with no code review findings, no Security Architecture Review findings, and no actionable suggestions. The code review was throttled due to free OSS review limits being reached. No changes to the diff are needed.
**Reply posted:** https://github.com/petry-projects/.github-private/pull/2290#issuecomment-6110988068
The maintainer-comment gate will recognize the `disposition=informational` marker and clear this as a non-actionable operational notice, allowing the PR to proceed.

[don-petry]

No description provided.

[don-petry]

Fixed in scripts/dev-lead-fix-reviews.sh: updated PASS_STARTED_AT to use millisecond precision (line 89) and updated regex patterns (lines 487, 935) to accept milliseconds, ensuring each pass gets a unique read_at timestamp even when starting in the same second.

[don-petry]

No description provided.

[donpetry-bot]

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T17:35:26Z.

[don-petry]

Dev-Lead — fix-reviews (applied)

Changes committed and pushed. Requested items addressed:

• scripts/dev-lead-retry.sh:517 — applied

[don-petry]

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

[don-petry]

No description provided.

[don-petry]

No description provided.

[donpetry-bot]

No description provided.

[don-petry]

No description provided.

[don-petry]

This is a CodeRabbit rate-limit notice indicating the free OSS review quota has been exhausted. No code changes are needed — it is an operational notice from the bot service.

[don-petry]

No description provided.

[don-petry]

Quality Gate has passed with all SonarCloud checks successful. The comment lists "1 New issue" but provides no specific file, line number, or issue details. After reviewing all changed files for known SonarQube hotspot patterns (script injection, hardcoded credentials, dynamic code execution), no actionable findings were identified. The PR's code changes appear sound.

[don-petry]

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

  - No unsafe `eval` with user input (test eval uses controlled script paths)
  - No dynamic code execution vulnerabilities
**Resolution:**
- Posted disposition reply explaining that despite the "1 New issue" reference, no specific actionable defect is provided in the comment
- Dispositioned as `answered` since the Quality Gate has passed and no actionable findings could be identified
**Files analyzed:** 
- scripts/dev-lead-fix-reviews.sh
- scripts/dev-lead-retry.sh  
- tests/dev-lead/unit/test_*.bats
**Result:** No actionable fixes required. Comment dispositioned.

[don-petry]

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push