Skip to content

chore: sync 3 org-standard workflow stub(s) from combsmith/.github #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
don-petry wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: sync 3 org-standard workflow stub(s) from combsmith/.github #2366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1bae13d
chore: sync 3 org-standard workflow stub(s) from combsmith/.github
don-petry Oct 19, 2026
757ad6a
chore: sync 3 org-standard workflow stub(s) from combsmith/.github
don-petry Oct 19, 2026
f1f14ce
chore: sync 3 org-standard workflow stub(s) from combsmith/.github
don-petry Oct 19, 2026
ce3caf5
Merge branch 'main' into standards-sync/workflows-20261019
don-petry Nov 7, 2026
670a50c
Merge branch 'main' into standards-sync/workflows-20261019
don-petry Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/add-to-project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@
add-to-project:
permissions:
contents: read
uses: combsmith/.github/.github/workflows/add-to-project-reusable.yml@add-to-project/v1-stable # NOSONAR(githubactions:S7637) first-party channel ref
uses: combsmith/.github/.github/workflows/add-to-project-reusable.yml@add-to-project/v1-next # NOSONAR(githubactions:S7637) first-party channel ref

@don-petry don-petry Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declined — change the template instead: this stub is synced verbatim from https://github.com/combsmith/.github/blob/main/standards/workflows/add-to-project.yml, so a change here drifts from the template and the next sync reverts it.

@don-petry don-petry Oct 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[High] Repinning uses: and agent_ref: to add-to-project/v1-next while leaving line 10's header comment (are pinned to the \add-to-project/v1-stable` channel and move with it) breaks tests/test_channel_pin_consistency.bats (LIVE: every .github/workflows/*.yml caller stub is comment/pin consistent), which fails via cpc_stub_conflictswithcomment names channel `add-to-project/v1-stable` but `uses:` pins `add-to-project/v1-next`. Either keep add-to-project.ymlpinned toadd-to-project/v1-stable` or update the comment in lockstep.

with:
project_id: PVT_kwDOD2inqs4BZq3-
project_url: https://github.com/orgs/combsmith/projects/1
agent_ref: add-to-project/v1-stable
agent_ref: add-to-project/v1-next
# Pass only the secrets the reusable declares (least privilege; avoids
# `secrets: inherit` handing the reusable every org secret).
secrets:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/agent-shield.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@

jobs:
agent-shield:
uses: combsmith/.github/.github/workflows/agent-shield-reusable.yml@agent-shield/v2-stable # NOSONAR(githubactions:S7637) first-party channel ref
uses: combsmith/.github/.github/workflows/agent-shield-reusable.yml@agent-shield/v2-next # NOSONAR(githubactions:S7637) first-party channel ref

@don-petry don-petry Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declined — change the template instead: this stub is synced verbatim from https://github.com/combsmith/.github/blob/main/standards/workflows/agent-shield.yml, so a change here drifts from the template and the next sync reverts it.

@don-petry don-petry Oct 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[High] Repinning .github/workflows/agent-shield.yml from @agent-shield/v2-stable to @agent-shield/v2-next breaks the agent-shield-stub CI job in .github/workflows/test-dev-lead.yml (tests/dev-lead/integration/test_agent_shield_stub.py), which enforces EXPECTED_USES = "combsmith/.github/.github/workflows/agent-shield-reusable.yml@agent-shield/v2-stable". In deploy-standard-workflows.sh, .github-private is listed in SKIP_SELF_MANAGED for agent-shield.yml, so this stub should remain pinned to @agent-shield/v2-stable.

4 changes: 2 additions & 2 deletions .github/workflows/dev-lead.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# ─────────────────────────────────────────────────────────────────────────────
# Dev-Lead Agent — thin caller stub
# Standard: combsmith/.github/standards/ci-standards.md#5-dev-lead-agent
Expand Down Expand Up @@ -69,9 +69,9 @@
# Promotion is done by moving the channel tags centrally; this
# caller is never edited on release. agent_ref threads the same channel into
# dev-lead's own scripts/prompts checkout. See https://github.com/combsmith/.github/blob/main/standards/ci-standards.md#dev-lead-agent.
uses: combsmith/.github-private/.github/workflows/dev-lead-reusable.yml@dev-lead/v139-ring0 # NOSONAR(githubactions:S7637) first-party channel ref
uses: combsmith/.github-private/.github/workflows/dev-lead-reusable.yml@dev-lead/v139-next # NOSONAR(githubactions:S7637) first-party channel ref

@don-petry don-petry Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped — first-party channel tag (dev-lead/v139-next) — intentional mutable ref per AGENTS.md, the release/rollback mechanism; not SHA-pinning it.

Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
with:
agent_ref: dev-lead/v139-ring0
agent_ref: dev-lead/v139-next
secrets: inherit # NOSONAR(githubactions:S7635) first-party trusted reusable
permissions:
contents: write
Expand Down
Loading