Skip to content

[probe] AgentShield severity gate — do not merge - #628

Closed
don-petry wants to merge 1 commit into
mainfrom
claude/agentshield-gate-probe
Closed

don-petry wants to merge 1 commit into
mainfrom
claude/agentshield-gate-probe

Conversation

@don-petry

@don-petry don-petry commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Temporary draft to confirm the AgentShield reusable fails at its configured min-severity (combsmith/.github#1436). It pins the reusable to the merge commit of combsmith/.github#1438 and runs on main as it is today. Expected: agent-shield / AgentShield fails. It will be closed and the branch deleted once the run is recorded.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

Problem

See the linked issue.

Risk

Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.

Test plan

No test files were added or updated. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the existing CI (bats + lint) guards the change.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

Parsing errors: 1
Validation error: Invalid input: expected string, received object at "reviews.path_filters[3]"
Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #628
No changes were committed, but the PR still can't be marked done: required checks Go, SonarCloud, TypeScript, agent-shield / AgentShield, dependency-audit / Detect ecosystems are still pending. The retry cron will re-attempt automatically. Next attempt after: 2026-11-03T04:12:17Z

@don-petry

Copy link
Copy Markdown
Contributor Author

Note

@don-petry I reviewed this PR and no code changes were needed, but I can't mark it done yet: required checks Go, SonarCloud, TypeScript, agent-shield / AgentShield, dependency-audit / Detect ecosystems are still pending. I'll re-check automatically.
Next attempt after: 2026-11-03T04:12:17Z

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Probe recorded: agent-shield / AgentShield failed at the configured threshold (1 high finding), as expected: https://github.com/combsmith/broodly/actions/runs/41572913028. Closing; the finding itself is fixed in #627.

@don-petry don-petry closed this Nov 3, 2026
@don-petry
don-petry deleted the claude/agentshield-gate-probe branch November 3, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants