[Fleet Monitor] combsmith/google-app-scripts — .github/workflows/sonarcloud.yml #669

Activity

1. don-petry

   added

   health-check

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   fleet-tracker

   on Nov 5, 2026
2. don-petry commented on Nov 5, 2026

   

   don-petry

   on Nov 5, 2026

   CollaboratorAuthor

   More actions

   Dev-Lead Implementation Plan

   Issue: #669 — [Fleet Monitor] combsmith/google-app-scripts — .github/workflows/sonarcloud.yml

   Scope

   Look into why sonarcloud.yml is over the failure-rate threshold. Finding: the workflow has no defect, so no code change is planned.

   Root-cause analysis

   I pulled logs for the failed runs in the monitored window. Both were pull_request runs on feature branches that had real problems at that commit. Neither failure came from the workflow, the runner, or SonarCloud itself.

   Run	Branch	Failing step	Cause	Later fixed?
   41915491839	fix/npm-audit-glob-minimatch	npm ci	EUSAGE: package.json overrides were out of sync with package-lock.json (Missing: glob@10.5.0 from lock file). CI failed on the same commit too.	Yes — the next push on that branch (41932716222) passed, then merged as #667
   41767247510	dev-lead/issue-665-…	npm test	19 suites failed with TypeError: The "original" argument must be of type function from in-progress code on that PR	Yes — later pushes passed, then merged as #666

   Every run of this workflow on main succeeded. The 14.3% rate (1/7) is the job doing what it should: rejecting broken PR commits that were fixed before merge.

   I also ran the workflow's steps locally against current main (npm ci --ignore-scripts, then npm test -- --coverage --coverageThreshold='{}'). Both succeed: 23/23 suites, 1130/1130 tests.

   Implementation Checklist

   • Check the workflow config (SHA-pinned actions, token-gated scan step, coverage step that ignores thresholds). No change needed.
   • Check the failed-run logs. Both failures came from the PR code, not the workflow.

   Tests to Write

   None. This is a config/diagnostic issue with no behavior change, so the TDD phase does not apply.

   Test Command

   npm test

   Recommendation

   Close as not a workflow defect. If the Fleet Monitor should stop flagging this kind of failure, it could count only push/main runs, or leave out PR runs whose failure also shows up in CI on the same SHA. That change would go in the monitor, not in this repo.
3. don-petry commented on Nov 8, 2026

   

   don-petry

   on Nov 8, 2026

   CollaboratorAuthor

   More actions

   ✅ Auto-resolved by Fleet Monitor. This workflow's failure rate has been below the 10% threshold (or the workflow was removed) since 2026-11-05 (3 days) — the monitor stopped flagging it. Closing. It will reopen automatically if the workflow crosses the threshold again.
4. don-petry

   closed this as completedon Nov 8, 2026