Skip to content

fix(feature-ideation): re-dispatch only for authors with write access - #663

Merged
don-petry merged 1 commit into
mainfrom
fix/feature-ideation-redispatch
Nov 3, 2026
Merged

don-petry merged 1 commit into
mainfrom
fix/feature-ideation-redispatch

Conversation

@don-petry

@don-petry don-petry commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Updates the redispatch job of .github/workflows/feature-ideation.yml to the current template in combsmith/.github (#1447, #1452). Only that job and its trigger comment change. project_context, the schedule and the channel pin are untouched.

  • New Ideas are re-dispatched only when the author has admin or write permission on this repo.
  • The dispatch uses the job token with actions: write. The personal token is no longer referenced.

Verified live on combsmith/.github: a maintainer's Idea produced one enhancement comment, and an Idea from an account without write access started no run.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Workflow Updates
    • Automatic enhancement now starts only for new Ideas opened by contributors with write access or higher.
    • Requests from contributors without sufficient access are skipped with a notice.

Problem

See the linked issue.

Risk

Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.

Test plan

No test files were added or updated. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the existing CI (bats + lint) guards the change.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.

Sync the redispatch job with the combsmith/.github template.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 3, 2026 13:09
@chatgpt-codex-connector

This comment has been minimized.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Walkthrough

The workflow description now limits automatic enhancement to new Ideas opened by contributors with write access. The redispatch job uses the workflow token and checks the discussion author's repository permission before proceeding.

Changes: Ideation redispatch

Layer / File(s) Summary
Redispatch permission gate
.github/workflows/feature-ideation.yml
The trigger description specifies the write-access condition. The job retains its event, category, and non-Bot conditions, uses github.token, and proceeds only for authors with admin or write permission. Other permissions produce a notice and a successful exit.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: donpetry-bot, rachel-petry

Merge Risk: Low · up to 49ba6

Add the required gate tests and address unsuccessful skips before merging.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: re-dispatch occurs only for authors with write access.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between c698464 and 49ba67d.

Files selected for processing: 1
  • .github/workflows/feature-ideation.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #663
No changes were committed, but the PR still can't be marked done: required checks SonarCloud, agent-shield / AgentShield, coverage, dependency-audit / Detect ecosystems are still pending. The retry cron will re-attempt automatically. Next attempt after: 2026-11-03T13:47:01Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but I can't mark it done yet: required checks SonarCloud, agent-shield / AgentShield, coverage, dependency-audit / Detect ecosystems are still pending. I'll re-check automatically.
Next attempt after: 2026-11-03T13:47:01Z

@don-petry
don-petry enabled auto-merge (squash) November 3, 2026 13:17

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix comments: Fix CodeRabbit comments on this PR

Comment thread .github/workflows/feature-ideation.yml Resolved
Comment thread .github/workflows/feature-ideation.yml Resolved
@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@donpetry-bot

donpetry-bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@don-petry
don-petry disabled auto-merge November 3, 2026 13:36
@don-petry

Copy link
Copy Markdown
Collaborator Author

Codex code review could not complete due to account usage limits. No actionable code findings to address.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Codex account usage limit reached — operational notice only. No code changes needed. Review can be retried after upgrading account or adding credits.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
The dependency audit failures (`dependency-audit / npm audit` and `dependency-audit / Audit gate`) appear to be pre-existing repo issues unrelated to this PR's changes, which only modify `.github/workflows/feature-ideation.yml` without touching any dependency files.
## Summary
**Bot:** chatgpt-codex-connector[bot]
**Issues addressed:** 2
- **Code review failed due to Codex usage limits** — operational notice only, no code findings reported [issued comment: disposition=informational]
- **Codex account usage limit reached** — operational notice only, no code changes needed [issue comment: disposition=informational]
**Files changed:** None (no code fixes needed)
**Pre-existing blockers noted:** 
- `dependency-audit / npm audit` failure — unrelated to PR changes, pre-existing repo issue
- `dependency-audit / Audit gate` failure — unrelated to PR changes, pre-existing repo issue

@don-petry
don-petry enabled auto-merge (squash) November 3, 2026 13:37
@don-petry

Copy link
Copy Markdown
Collaborator Author

No description provided.

@don-petry
don-petry disabled auto-merge November 3, 2026 16:30
@don-petry
don-petry enabled auto-merge (squash) November 3, 2026 16:30
@don-petry
don-petry disabled auto-merge November 3, 2026 16:31
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-reviews (no-changes)

Agent reasoning
Addressed 0 threads:
- Thread PRRT_kwDORFz9wc6zI6rO (`.github/workflows/feature-ideation.yml:129`, 404 handling on the permission lookup): skipped. This file is a synced org stub whose header reads `SOURCE OF TRUTH: combsmith/.github/standards/workflows/feature-ideation.yml`, so it is read-only here. The thread already has a decline reply saying the template in `combsmith/.github` should take the change. I made no code change and posted no addressed-marker or claim.
CI:
- **`dependency-audit / npm audit` and `Audit gate`:** both fail. Running `npm audit` locally reports 29 moderate vulnerabilities, all in dev dependencies (the `eslint` and `@typescript-eslint` chain, via `minimatch`). The PR only changes a workflow file and doesn't touch `package.json` or the lockfile. Clearing them would mean `npm audit fix --force` with breaking dev-tooling upgrades, which goes beyond this PR. I left them for a separate dependency-update PR. Dev-lead has no tracking-issue comment to add here, because there is no review thread or issue comment for this failure.
- **`dev-lead` runs:** they are still pending or in progress. They are the harness's own runs, so they aren't blockers.
There are no `CHANGES_REQUESTED` reviews, and there are no PR issue comments that I know of needing a disposition. The reviews listed are all `COMMENTED`. I did not enumerate the issue comments.
Test verification: not run, because I made no changes.
Files changed: none.

@don-petry
don-petry enabled auto-merge (squash) November 3, 2026 16:32
@don-petry
don-petry merged commit 03f77cc into main Nov 3, 2026
69 of 99 checks passed
@don-petry
don-petry deleted the fix/feature-ideation-redispatch branch November 3, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants