Skip to content

The owed Muse reads of #632 and #639: three boundary cases and their mutants - #668

Open
don-petry wants to merge 2 commits into
mainfrom
tests/owed-muse-reads
Open

The owed Muse reads of #632 and #639: three boundary cases and their mutants#668
don-petry wants to merge 2 commits into
mainfrom
tests/owed-muse-reads

Conversation

@don-petry

@don-petry don-petry commented Nov 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The findings owed by the Muse reads of PRs that merged before Muse could read them, as the merged-early rule asks. Muse read #632, #637, #638, #639 and #650 once it was answering again.

PR Muse found Here
#632 (issue 626) Major: nothing tests or mutates the plan's heads_place call. Placing the heads by their path alone, with no containment check, passed every eval test tests/test_evals.py::EvalJob.test_each_head_is_unpacked_apart_from_the_cases now links a heads folder to a place in the workspace that does not exist yet. The plan stops with scratch_in_workspace and makes nothing there. New mutant: "the plan places the heads by their path alone"
#639 (issue 608) Major: nothing holds that description_anchor takes the records with no default tests/test_decide.py::Convergence.test_an_approval_is_anchored_at_the_act_that_read_the_description now calls it without runs and expects a TypeError. New mutant: "the description's anchor takes no records by default"
#639 (issue 608) Minor: the world's fallback was untested for a Run in the approval's own second tests/test_simulator.py::Simulation.test_the_worlds_reading_of_an_edit_after_the_approval_is_the_kernels gains that case. New mutant: "the world takes a Run in the approval's own second as after it"
#637 Nothing —
#638 3 majors: a nested def shadowing a text constant, a bytes command, and a class body in the class's own module #650 holds the first two, and record 0171 names the third as not held
#650 4 majors: more check_writes routes Added to #655, which the Factory Builder has parked

No code changes and no record: only boundary cases and their mutants, all killed.

Protected path: tests/test_simulator.py. It gets one case. Pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder.

Verify

make verify on an export of 2036fdc, up to date with main: 1716 tests, OK (8 expected failures).

Reviews

Read State
Claude + security Nothing blocking. Each case passes, and fails only under its own mutant. Its one minor point, that the TypeError should name runs, is in the second commit
Argon clean
Muse its reads are this PR's source
Astra not run
Codex automatic

🤖 Generated with Claude Code

@don-petry @claude
The owed Muse reads of #632 and #639: three boundary cases and their …
2036fdc 
…mutants

#632 (issue 626): the plan places the heads by heads_place, so a heads folder linked into the workspace stops it before
it makes anything there. #639 (issue 608): description_anchor takes the records always, with no default; and the world
dates an approval by a Run of the item in its own second.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 9, 2026 04:33
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-09T04:33:24.277459Z
We couldn’t complete this review. Comment @codex review to try again.		 2036fdc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@don-petry @claude
#668: the anchor's missing records are the TypeError's cause, by name
431c899 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@don-petry