Skip to content

test: keep option type fixtures compatible with newer lint rules - #63

Merged
tensornull merged 1 commit into
mainfrom
ci/type-fixture-lint-20261019
Oct 19, 2026
Merged

tensornull merged 1 commit into
mainfrom
ci/type-fixture-lint-20261019

Conversation

@tensornull

Copy link
Copy Markdown
Contributor

Summary

The compatible Dependabot development update fails lint because newer typescript-eslint rejects the void array used to mark negative type-fixture variables as used. Export those test-module bindings instead. All @ts-expect-error assertions and constructor/options calls stay in place, and the SDK's packaged source and exports are unaffected.

Verification

  • Node.js 24.15.0: npm run verify passed completely on the clean committed HEAD, including all 576 tests, package and example checks, packed fixtures, minimum/locked/latest OpenAI compatibility, actionlint 1.7.12, and exact-HEAD self-containment.
  • In an isolated candidate using PR chore(deps-dev): bump the development-dependencies group across 1 directory with 7 updates #62's complete development lockfile, reproduced the original @typescript-eslint/no-meaningless-void-operator failure, then verified the repaired fixture with npm run lint, npm run typecheck, npm test (576 passing tests), and npm run format:check.
  • Confirmed the negative type-assertion count is unchanged and git diff --check passes.

Root dependency versions and lint rules are unchanged. Remote Actions will be checked on this PR's exact head before merge; local checks make no live API or registry-publication claim.

Checklist

  • The change is within the current roadmap milestone.
  • Public behavior, compatibility claims, and examples are documented.
  • Unit, mocked contract, type, lint, format, build, and package checks pass as applicable.
  • Packed ESM, CommonJS, and compatible-OpenAI host fixtures pass as applicable.
  • No credential, private prompt, customer data, generated build output, or local dependency directory is included.
  • Workflow edits pass the repository-pinned actionlint version.
  • Remote Actions, live API, and registry evidence are not claimed from local validation.

@tensornull
tensornull merged commit 519a658 into main Oct 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant