Repository navigation
test: keep option type fixtures compatible with newer lint rules - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The compatible Dependabot development update fails lint because newer typescript-eslint rejects the
voidarray used to mark negative type-fixture variables as used. Export those test-module bindings instead. All@ts-expect-errorassertions and constructor/options calls stay in place, and the SDK's packaged source and exports are unaffected.Verification
npm run verifypassed completely on the clean committed HEAD, including all 576 tests, package and example checks, packed fixtures, minimum/locked/latest OpenAI compatibility, actionlint 1.7.12, and exact-HEAD self-containment.@typescript-eslint/no-meaningless-void-operatorfailure, then verified the repaired fixture withnpm run lint,npm run typecheck,npm test(576 passing tests), andnpm run format:check.git diff --checkpasses.Root dependency versions and lint rules are unchanged. Remote Actions will be checked on this PR's exact head before merge; local checks make no live API or registry-publication claim.
Checklist
actionlintversion.