Modernize commander for the current Ruby ecosystem

.github/workflows/ci.yml

@@ -0,0 +1,67 @@
+name: CI
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    name: Ruby ${{ matrix.ruby }}
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby:
+          - '3.1'
+          - '3.2'
+          - '3.3'
+          - '3.4'
+          - '4.0.6'
+          - jruby
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - name: Run tests
+        run: bundle exec rake spec
+
+  lint:
+    name: RuboCop
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '4.0.6'
+          bundler-cache: true
+
+      - name: Run RuboCop
+        run: bundle exec rubocop
+
+  security:
+    name: Bundler Audit
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '4.0.6'
+          bundler-cache: true
+
+      - name: Run bundler-audit
+        run: bundle exec bundler-audit check --update

.gitignore

@@ -3,5 +3,4 @@
 Gemfile.lock
 pkg/*
 .rvmrc
-.ruby-version
 coverage/*

.necro/summary.json

@@ -0,0 +1,21 @@
+{
+  "blocked": false,
+  "blocked_reason": null,
+  "dependency_changes": [
+    "highline: ~> 3.0.0 -> ~> 3.1 (3.1.2)",
+    "rake: unpinned -> ~> 13.0 (moved from gemspec to Gemfile dev group)",
+    "rspec: ~> 3.2 -> ~> 3.13",
+    "rubocop: ~> 1.12.1 -> ~> 1.88",
+    "simplecov: unpinned -> ~> 1.0 (moved from gemspec to Gemfile dev group)",
+    "added bundler-audit ~> 0.9 (new dev dependency, security auditing)",
+    "removed optional growl integration (Growl.app discontinued; dead upstream service)"
+  ],
+  "security_findings": [
+    "bundler-audit check --update: no vulnerabilities found in original or updated dependency set (no CVEs to resolve)"
+  ],
+  "coverage_before": 84.28,
+  "coverage_after": 100.0,
+  "reviewer_feedback_applied": [
+    "PR #103 round 2: removed the '.necro/' and 'NECRO_MODERNIZATION_REPORT.md' entries added to .gitignore in round 1, and restored both files as tracked content"
+  ]
+}

.rubocop.yml

@@ -1,7 +1,7 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 3.0
+  TargetRubyVersion: 3.1
   NewCops: enable
   SuggestExtensions: false
 
@@ -54,9 +54,6 @@ Style/FormatStringToken:
 Style/MixinUsage:
   Enabled: false
 
-Lint/ErbNewArguments:
-  Enabled: false
-
 Style/DocumentDynamicEvalDefinition:
   Enabled: false
 

.rubocop_todo.yml

@@ -1,77 +1,81 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2015-02-16 16:08:54 -0800 using RuboCop version 0.29.0.
+# This configuration was generated by
+# `rubocop --auto-gen-config --no-auto-gen-timestamp`
+# using RuboCop version 1.88.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-Security/Eval:
-  Enabled: false
-
-# Offense count: 2
+# Offense count: 1
+# Configuration parameters: AllowComments, AllowNil.
 Lint/SuppressedException:
-  Enabled: false
+  Exclude:
+    - 'lib/commander/user_interaction.rb'
 
-# Offense count: 5
+# Offense count: 6
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 30
 
 # Offense count: 1
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Enabled: false
+  Max: 250
 
-# Offense count: 4
+# Offense count: 5
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 13
 
-# Offense count: 89
-# Configuration parameters: AllowURI, URISchemes.
-Layout/LineLength:
-  Max: 242
-
-# Offense count: 7
-# Configuration parameters: CountComments.
+# Offense count: 8
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 36
 
-# Offense count: 4
+# Offense count: 5
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
   Max: 14
 
-# Offense count: 1
+# Offense count: 2
 Naming/AccessorMethodName:
-  Enabled: false
-
-# Offense count: 18
-Style/Documentation:
-  Enabled: false
-
-# Offense count: 12
-# Configuration parameters: AllowedVariables.
-Style/GlobalVars:
-  Enabled: false
+  Exclude:
+    - 'lib/commander/core_ext/object.rb'
+    - 'lib/commander/help_formatters.rb'
 
 # Offense count: 1
-# Configuration parameters: MaxLineLength.
+Security/Eval:
+  Exclude:
+    - 'lib/commander/delegates.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
 Style/IfUnlessModifier:
-  Enabled: false
+  Exclude:
+    - 'lib/commander/runner.rb'
+    - 'lib/commander/user_interaction.rb'
 
 # Offense count: 1
 Style/MultilineBlockChain:
-  Enabled: false
+  Exclude:
+    - 'lib/commander/user_interaction.rb'
 
 # Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
 Style/MultilineTernaryOperator:
-  Enabled: false
+  Exclude:
+    - 'lib/commander/user_interaction.rb'
 
-# Offense count: 5
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
 Style/RescueModifier:
-  Enabled: false
+  Exclude:
+    - 'lib/commander/runner.rb'
+    - 'lib/commander/user_interaction.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
-Style/TrivialAccessors:
-  Enabled: false
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, AllowRBSInlineAnnotation, AllowCopDirectives, AllowedPatterns, SplitStrings.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 242

.ruby-version

@@ -0,0 +1 @@
+4.0.6

Gemfile

@@ -3,3 +3,11 @@
 source 'https://rubygems.org'
 
 gemspec
+
+group :development, :test do
+  gem 'bundler-audit', '~> 0.9'
+  gem 'rake', '~> 13.0'
+  gem 'rspec', '~> 3.13'
+  gem 'rubocop', '~> 1.88'
+  gem 'simplecov', '~> 1.0'
+end