Skip to content

fix(sync-actions): correct Counter literal and pin platform-sdk off latest #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajimae merged 3 commits into from
Sep 24, 2026
Merged

fix(sync-actions): correct Counter literal and pin platform-sdk off latest #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0fdc55
fix(sync-actions): use correct `Counter` literal for skipConfiguratio…
ajimae Sep 24, 2026
ca67eb4
chore(sync-actions): replace `latest` platform-sdk range with `^9.4.0`
ajimae Sep 24, 2026
ba27b2a
docs(changeset): note the platform-sdk range change
ajimae Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/pin-platform-sdk-range.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@commercetools/sync-actions': patch
---

Replace the `latest` version range for `@commercetools/platform-sdk` with `^9.4.0`.

The `latest` descriptor re-resolved on every lockfile refresh and crossed major boundaries without review, which is how the 8.x to 9.x upgrade landed unannounced. A caret range matches the other packages in this repository and routes future updates through reviewable dependency PRs, with major upgrades gated behind explicit approval.

This is a dependency-declaration change only. The public API and observable behavior of `@commercetools/sync-actions` are unchanged.
2 changes: 1 addition & 1 deletion packages/sync-actions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"test": "jest --runInBand"
},
"dependencies": {
"@commercetools/platform-sdk": "latest",
"@commercetools/platform-sdk": "^9.4.0",
"esbuild": "^0.25.4",
"fast-equals": "^2.0.0",
"jest": "^29.7.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/sync-actions/test/recurring-orders-sync.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,11 @@ describe('Actions', () => {

test('should build `setOrderSkipConfiguration` action', () => {
const before: Partial<RecurringOrder> = {
skipConfiguration: { type: 'counter', totalToSkip: 2, skipped: 1 },
skipConfiguration: { type: 'Counter', totalToSkip: 2, skipped: 1 },
};
const now: Partial<RecurringOrder> = {
skipConfiguration: {
type: 'counter',
type: 'Counter',
totalToSkip: 5,
skipped: 0,
},
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1826,12 +1826,12 @@ __metadata:
languageName: node
linkType: hard

"@commercetools/platform-sdk@npm:latest":
version: 9.4.0
resolution: "@commercetools/platform-sdk@npm:9.4.0"
"@commercetools/platform-sdk@npm:^9.4.0":
version: 9.5.0
resolution: "@commercetools/platform-sdk@npm:9.5.0"
dependencies:
"@commercetools/ts-client": "npm:^5.0.2"
checksum: 10c0/994ee28f20f1c607a56f98136ff71a2b317363ff755518fc398433ae704966e92faaa09752c4c3d6eecb4b10b437fa5e56815e4960c24cf910c32394991cee99
checksum: 10c0/738d841844dce697cd90d3cac647f577eb347a61d74dd3d4be8591d3d4766807be26c0b584a7910869ceaff3b25796470d41e906da69ccf843e950c5b10c8333
languageName: node
linkType: hard

Expand Down Expand Up @@ -1864,7 +1864,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@commercetools/sync-actions@workspace:packages/sync-actions"
dependencies:
"@commercetools/platform-sdk": "npm:latest"
"@commercetools/platform-sdk": "npm:^9.4.0"
esbuild: "npm:^0.25.4"
fast-equals: "npm:^2.0.0"
jest: "npm:^29.7.0"
Expand Down
Loading