Repository navigation
Conversation
…topped The checks before the settings menu waited on pveversion, two pvesm status calls, pvesh and, on clusters, pvecm, one after the other. core/build.func now starts them in the background before it downloads the engine; the checks read the results through _cs_probe_read and run a command themselves only when its probe failed or never ran. The storage check trusts a probe's yes and asks a no again live. Telemetry starts with the install record the build sends. A run that ends before it, in the checks or a dialog, reports nothing: a host that is not ready is not a failed install, and these runs made up a third of the failures since 27 October. Tools and add-ons have no such point, so their "requirement not met" codes send nothing either. root_check now runs before pve_check. As another user /etc/pve/storage.cfg is unreadable, and the cluster check reported a damaged cluster. log_msg and log_section no longer end a run when the log cannot be written.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/prechecks-parallel-no-telemetry \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"Swap This PR touches Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/prechecks-parallel-no-telemetry/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/prechecks-parallel-no-telemetryNote that Useful flags while testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
The checks before the settings menu waited on pveversion, two pvesm status calls, pvesh and, on clusters, pvecm, one after the other. core/build.func now starts them in the background before it downloads the engine; the checks read the results through _cs_probe_read and run a command themselves only when its probe failed or never ran. The storage check trusts a probe's yes and asks a no again live.
Telemetry starts with the install record the build sends. A run that ends before it, in the checks or a dialog, reports nothing: a host that is not ready is not a failed install, and these runs made up a third of the failures since 27 October. Tools and add-ons have no such point, so their "requirement not met" codes send nothing either.
root_check now runs before pve_check. As another user /etc/pve/storage.cfg is unreadable, and the cluster check reported a damaged cluster. log_msg and log_section no longer end a run when the log cannot be written.
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🤖 AI Assistance (X in brackets)
🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.