Skip to content

feat: add var_cmode to set the container console mode - #180

Open
MickLesk wants to merge 3 commits into
mainfrom
feat/var-cmode
Open

MickLesk wants to merge 3 commits into
mainfrom
feat/var-cmode

Conversation

@MickLesk

Copy link
Copy Markdown
Member

✍️ Description

pct leaves cmode at tty. (Proxmox Default) On Debian 13 that console corrupts multiline pastes (community-scripts/ProxmoxVE#18303), and cmode shell avoids it, but it also skips the login prompt - so this stays opt-in instead of becoming a new default.

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

pct leaves cmode at tty. On Debian 13 that console corrupts multiline
pastes (community-scripts/ProxmoxVE#18303), and cmode shell avoids it,
but it also skips the login prompt - so this stays opt-in instead of
becoming a new default.
@github-actions

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/feat/var-cmode \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

This PR touches pve/, so it needs a Proxmox VE host.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/feat/var-cmode/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/feat/var-cmode

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

New step 28 between Container Protection and mknod; the steps after it
shift by one and MAX_STEP goes to 32. Picking tty clears the value
rather than passing -cmode tty, since that is what pct does anyway.
Without var_pw, lxc/install.func deletes the root password and puts
--autologin root on both container-getty@ and console-getty, so tty and
console already drop into a root shell. The dialog claimed they showed
a login prompt and that only shell skipped it; that is only true once
var_pw is set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant