Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 77.40% 76.46% -0.95%
==========================================
Files 55 55
Lines 9436 9571 +135
==========================================
+ Hits 7304 7318 +14
- Misses 2132 2253 +121 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jcurtis2
self-requested a review
July 22, 2026 21:24
Author
|
I've pushed the updates addressing the CAMP issue. The CI checks are showing "Action required" — could you approve the workflow runs when you get a chance? Thanks! |
aero_particle_crit_diameter_est started Newton far from the root and, for organic-film particles whose Kohler curve S(D) is double-peaked, converged to the wrong (outer) root -- a larger critical diameter and lower critical supersaturation -- or diverged to NaN. Replace the far-start Newton with a coarse logarithmic scan for the global maximum of S(D) plus a bracketed Newton (rtsafe) refinement. The EST physics is unchanged; only the root finding. Also address code-review items in the org_film branch: - set eff_surf_eng on the hydrophobic (kappa < 1e-30) early return - guard vol(0) for absent species, 0/0 in surf_eng_organic, and v_sol <= 0 - retire the obsolete d >= dry_diam assert; repurpose the remaining warning to flag a maximum above the scan range - read aero_sigma with must_be_present=.false. for backward compatibility - use util.F90 sphere-geometry helpers (add sphere_diam2vol) - follow the i_spec/n_spec loop-variable convention - precompute per-particle soluble sums (aero_particle_soluble_sums) so the scan avoids repeated species-name lookups (~10x faster post-processing) ctest passes 14/14.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an effective surface tension (EST) treatment for CCN activation as an alternative to the existing constant surface tension assumption. Previously, Köhler-based CCN activation in PartMC assumed a fixed surface tension (typically that of pure water), which does not capture the surface-tension lowering caused by surface-active organics (surfactants). The new method estimates a composition-dependent effective surface tension per particle, so surfactant effects on droplet activation are represented explicitly.
Reference
The EST formulation and its evaluation follow: