Repository navigation
fix: WFPTNormalDrift normalisation when t0 > 0 - #8
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… before t0 The v_loc**2 term used RT instead of RT - t0, so the density integrated to less than 1 whenever t0 > 0 (the same bug fixed in WFPT in b13135d). Also computes in log space and returns -inf for RT <= t0 instead of NaN. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WFPTNormalDrift.log_probusedv_loc**2 * RTwhere Navarro-Fuss / Blurton want decision timeRT - t0, so the density integrated to less than 1 whenevert0 > 0(e.g. 0.30 atv=2, sv=1, t0=0.8). Same bugWFPThad before b13135d.get_choice_RTsstarts atdtinstead of 0, so the integration tests no longer pass RT = 0 (out of support) and stop raising out-of-support warnings.log(exp(...))round trip), and-infforRT <= t0instead of NaN whensv² (RT - t0) + 1 < 0.Tests
New (committed failing first, dc72d7c):
test_wfpt_normal_drift_integrate_to_one: integrates to 1 for t0 in {0, 0.5, 0.8}, v_scale up to 1.5, negative drift.test_wfpt_normal_drift_matches_wfpt_as_v_scale_vanishes: reduces toWFPTasv_scale -> 0.Before the fix: 4 failed (all
t0 > 0cases), 2 passed (t0 = 0).Full suite after:
The remaining warning is pytest declining to collect the
TestDistnamedtuple as a test class.🤖 Generated with Claude Code