Fix deprecation warning since conda 26.3 - #1316
Open
lrandersson wants to merge 2 commits into
Open
Conversation
lrandersson
marked this pull request as ready for review
August 6, 2026 18:10
conda-bot
added
the
cla-signed
marcoesters
reviewed
Aug 6, 2026
| if sys.platform.startswith("linux"): | ||
| try: | ||
| from conda._vendor import distro # noqa | ||
| import distro # noqa |
Contributor
There was a problem hiding this comment.
conda has been depending on distro for some time now. Did you verify that this applies to all supported version for constructor? If so, you can remove the try block and remove distro as a conditional dependency.
If not, I suggest
try:
import distro
except ImportError:
pass
if not distro:
try:
from conda._vendor import distro
except ImportError:
pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #1315.
As of right now I only added
distroto Linux to mimic the old behavior. However, let me know if we rather add it for all the platforms so I can remove the conditional imports which I'm personally not a big fan of.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?