Also expand parameters in lists of strings - #333
Open
hmaarrfk wants to merge 3 commits into
Open
Conversation
conda-bot
added
the
cla-signed
hmaarrfk
marked this pull request as ready for review
May 17, 2025 21:20
Author
|
Pointers on where to add a test would be appreciated if you want one. |
Contributor
tests/test_api.py is probably the best place for those tests. |
jaimergp
reviewed
Jun 24, 2025
|
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
Contributor
|
Not stale - this is a helpful addition, it just needs some tests. |
Previously if one had a list of strings, expressions such as
{{ PREFIX }} or {{ ENV_NAME }} would not get expanded
- [ ] Add a test
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
<details><summary>Claude's draft</summary> Add `test_render_expands_placeholders_in_lists` covering the new `Menu.render` behavior: placeholders are now expanded element-wise in lists and tuples of strings, while non-string items are returned untouched and scalar strings behave as before. Resume this Claude session: ``` cd /Users/mark/git/feedstocks/menuinst claude --resume 6d4c7180-d5eb-4848-baf7-d9c3bded4784 ``` </details>
hmaarrfk
force-pushed
the
expand_list_items_too
branch
from
June 27, 2026 01:49
a15d12c to
d67aedb
Compare
github-actions
Bot
added
stale::recovered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if one had a list of strings, expressions such as {{ PREFIX }} or {{ ENV_NAME }} would not get expanded
Description
I wanted to write a command that looks like
{{ PREFIX }}/bin/my_app-{{ ENV_NAME }}Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?