Fix docs deploy: make main.py importable in the mkdocs container - #1558
Open
v1r3n wants to merge 3 commits into
Open
Fix docs deploy: make main.py importable in the mkdocs container#1558v1r3n wants to merge 3 commits into
v1r3n wants to merge 3 commits into
Conversation
mkdocs.yml declares the mermaid custom fence as
`!!python/name:main.mermaid_fence`, which PyYAML resolves with a plain
`import main` while parsing the config. The deploy action runs the mkdocs
console script inside a Docker container, where sys.path[0] is the script's
bin directory rather than the checkout, so the import fails and the deploy
aborts before building.
Point PYTHONPATH at the container's workspace mount so main.py resolves.
Run 32411004435 failed with:
cannot find module 'main' (No module named 'main')
in "/github/workspace/mkdocs.yml", line 283, column 19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mkdocs.yml declares the mermaid custom fence as
!!python/name:main.mermaid_fence, which PyYAML resolves with a plainimport mainwhile parsing the config. The deploy action runs the mkdocs console script inside a Docker container, where sys.path[0] is the script's bin directory rather than the checkout, so the import fails and the deploy aborts before building.Point PYTHONPATH at the container's workspace mount so main.py resolves.
Run 32411004435 failed with:
cannot find module 'main' (No module named 'main')
in "/github/workspace/mkdocs.yml", line 283, column 19
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered
Enterprise UI Playwright Tests
Every PR automatically triggers the enterprise UI Playwright E2E test suite.
Tests run against conductor-ui
mainby default. To test against a differentconductor-ui branch, add this line anywhere in the PR description: