Skip to content

fix(examples): remove broken require.main guards and their importer examples #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ling-senpeng13 merged 1 commit into from
Aug 18, 2026
Merged

fix(examples): remove broken require.main guards and their importer examples #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions examples/agents/63-deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,7 @@ async function main() {
}
}

// Guard: 63c-run-by-name.ts imports docAssistant from this file — only run
// when executed directly, not on import.
if (require.main === module) {
main().catch((err) => {
console.error(err);
process.exitCode = 1;
});
}
main().catch((err) => {
console.error(err);
process.exitCode = 1;
});
41 changes: 0 additions & 41 deletions examples/agents/63c-run-by-name.ts
View file
Open in desktop

This file was deleted.

12 changes: 4 additions & 8 deletions examples/agents/63d-serve-from-package.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,7 @@ async function main() {
}
}

// Guard: 63e-run-monitoring.ts imports monitoringAgent from this file — only
// run when executed directly, not on import.
if (require.main === module) {
main().catch((err) => {
console.error(err);
process.exitCode = 1;
});
}
main().catch((err) => {
console.error(err);
process.exitCode = 1;
});
35 changes: 0 additions & 35 deletions examples/agents/63e-run-monitoring.ts
View file
Open in desktop

This file was deleted.

6 changes: 2 additions & 4 deletions examples/agents/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ In production, the three concerns are separated:
Every example includes the deploy/serve pattern as commented code at the bottom of its
`main()` function — look for the `// Production pattern:` comment.

See [63-deploy.ts](63-deploy.ts), [63b-serve.ts](63b-serve.ts), and
[63c-run-by-name.ts](63c-run-by-name.ts) for a complete working example of this pattern.
See [63-deploy.ts](63-deploy.ts) and [63b-serve.ts](63b-serve.ts) for a complete
working example of this pattern.

---

Expand Down Expand Up @@ -316,9 +316,7 @@ cd examples/agents/openai && npx tsx 01-basic-agent.ts
| 17 | [Scheduled Agent](17-scheduled-agent.ts) | Deploy an agent on a cron schedule |
| 63 | [Deploy](63-deploy.ts) | Register agent with the server |
| 63b | [Serve](63b-serve.ts) | Start a long-running worker |
| 63c | [Run by Name](63c-run-by-name.ts) | Execute a pre-deployed agent |
| 63d | [Serve from Package](63d-serve-from-package.ts) | Serve agents from a package |
| 63e | [Run Monitoring](63e-run-monitoring.ts) | Monitor running executions |

## End-to-End Use Cases

Expand Down
Loading