Repository navigation
feat: Implement issues 807, 808, 809, 810 - #828
Merged
Jaydbrown merged 5 commits intoOct 20, 2026
Merged
Conversation
…nection status changes to online (conduit-protocol#809)
…ter user creates their first stream (conduit-protocol#810)
|
@BaseDev-Eth Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements four requested enhancements across sorting, telemetry safety,
offline sync, and notification permissions.
#807 — Sort streams by accrued claimable balance (descending)
lib/stream-sort.ts: newclaimable-descsort key (CLAIMABLE_DESC),claimableBalance()andcompareClaimableDesc(), plus a new option inSORT_OPTIONS. Uses the on-chainwithdrawablevalue when available andotherwise derives
rate × elapsed − withdrawn(end-capped, paused-aware).#808 — Mask transaction secret keys and signatures before logging
lib/error-tracking.ts: redacts 56-charS…secret keys and 64-bytetransaction signatures (hex and base64) as
[REDACTED], plus labelledsignature/signed-XDR/envelope values. Breadcrumb messages and data are
scrubbed at insertion and again at Sentry dispatch.
#809 — Automatic sync retry when the connection returns online
lib/offline-transactions.ts: newstartOnlineSync/stopOnlineSyncbind an idempotent
windowonlinelistener that re-flushes the queuedtransactions, with burst de-duplication and an SSR/offline guard.
components/OfflineTransactionSync.tsxnow delegates to it.#810 — Request notification permission only after the first stream
lib/notifications.ts: first-stream + prompt-once gating(
hasCreatedStream,markFirstStreamCreated,shouldRequestNotificationPermission,requestNotificationPermissionAfterFirstStream,dismissNotificationPermissionPrompt).app/create/page.tsx: records first-stream creation and shows a newcontextual
FirstStreamNotificationPrompton the post-creation screen(the browser prompt is triggered by the user clicking "Enable notifications").
Tests
Unit tests were written/updated for all four issues:
lib/__tests__/stream-sort.test.tslib/error-tracking.test.tslib/offline-transactions.test.ts,components/__tests__/OfflineTransactionSync.test.tsxlib/notifications.test.ts,components/__tests__/FirstStreamNotificationPrompt.test.tsxCloses #807, Closes #808, Closes #809, Closes #810